From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pavel Hofman <pavel.hofman@ivitera.com>
Cc: linux-usb@vger.kernel.org,
Ruslan Bilovol <ruslan.bilovol@gmail.com>,
Felipe Balbi <balbi@kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH] usb: gadget: u_audio: Subdevice 0 for capture ctls
Date: Mon, 27 Dec 2021 10:22:57 +0100 [thread overview]
Message-ID: <YcmF8dFvcTeNdxSW@kroah.com> (raw)
In-Reply-To: <20211227065100.20873-1-pavel.hofman@ivitera.com>
On Mon, Dec 27, 2021 at 07:51:00AM +0100, Pavel Hofman wrote:
> Both capture and playback alsa devices use subdevice 0. Yet capture-side
> ctls are defined for subdevice 1. The patch sets subdevice 0 for them.
>
> Signed-off-by: Pavel Hofman <pavel.hofman@ivitera.com>
> ---
> drivers/usb/gadget/function/u_audio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/function/u_audio.c b/drivers/usb/gadget/function/u_audio.c
> index c46400be5464..4f6c0049c534 100644
> --- a/drivers/usb/gadget/function/u_audio.c
> +++ b/drivers/usb/gadget/function/u_audio.c
> @@ -1145,7 +1145,7 @@ int g_audio_setup(struct g_audio *g_audio, const char *pcm_name,
> }
>
> kctl->id.device = pcm->device;
> - kctl->id.subdevice = i;
> + kctl->id.subdevice = 0;
>
> err = snd_ctl_add(card, kctl);
> if (err < 0)
> @@ -1168,7 +1168,7 @@ int g_audio_setup(struct g_audio *g_audio, const char *pcm_name,
> }
>
> kctl->id.device = pcm->device;
> - kctl->id.subdevice = i;
> + kctl->id.subdevice = 0;
>
>
> kctl->tlv.c = u_audio_volume_tlv;
> --
> 2.25.1
>
Does this fix a specific bug/issue? If so, what commit does this fix?
thanks,
greg k-h
prev parent reply other threads:[~2021-12-27 9:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 6:51 [PATCH] usb: gadget: u_audio: Subdevice 0 for capture ctls Pavel Hofman
2021-12-27 9:22 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcmF8dFvcTeNdxSW@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=linux-usb@vger.kernel.org \
--cc=pavel.hofman@ivitera.com \
--cc=ruslan.bilovol@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).