From: Andrew Lunn <andrew@lunn.ch>
To: Aaron Ma <aaron.ma@canonical.com>
Cc: Oliver Neukum <oneukum@suse.com>,
kuba@kernel.org, henning.schild@siemens.com,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
hayeswang@realtek.com, tiwai@suse.de
Subject: Re: [PATCH] Revert "net: usb: r8152: Add MAC passthrough support for more Lenovo Docks"
Date: Wed, 5 Jan 2022 18:36:15 +0100 [thread overview]
Message-ID: <YdXXD3us3RnCuw4y@lunn.ch> (raw)
In-Reply-To: <fa192218-4fc8-678f-8b40-95b85e36097e@canonical.com>
On Thu, Jan 06, 2022 at 12:05:28AM +0800, Aaron Ma wrote:
>
> On 1/6/22 00:01, Oliver Neukum wrote:
> >
> > On 05.01.22 16:51, Aaron Ma wrote:
> > > This reverts commit f77b83b5bbab53d2be339184838b19ed2c62c0a5.
> > >
> > > This change breaks multiple usb to ethernet dongles attached on Lenovo
> > > USB hub.
> >
> > Hi,
> >
> > now we should maybe discuss a sensible way to identify device
> > that should use passthrough. Are your reasons to not have a list
> > of devices maintainability or is it impossible?
> >
>
> The USB to ethernet ID is 0bda:8153. It's is original Realtek 8153 ID.
> It's impossible.
>
> And ocp data are 0.
> No way to identify it's from dock.
Can you at least identify the dock?
Can you have a udev rule which matches on 0bda:8153, it then walks up
the tree and checks if it is part of the dock? And it is on the
expected port of the hub within the dock, and not a USB stick plugged
into the dock on some other port of the hub?
Andrew
next prev parent reply other threads:[~2022-01-05 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 15:51 [PATCH] Revert "net: usb: r8152: Add MAC passthrough support for more Lenovo Docks" Aaron Ma
2022-01-05 16:01 ` Oliver Neukum
2022-01-05 16:05 ` Aaron Ma
2022-01-05 17:36 ` Andrew Lunn [this message]
2022-01-05 19:09 ` Henning Schild
2022-01-05 18:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdXXD3us3RnCuw4y@lunn.ch \
--to=andrew@lunn.ch \
--cc=aaron.ma@canonical.com \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=henning.schild@siemens.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).