From: Richard Leitner <richard.leitner@linux.dev>
To: Tommaso Merciai <tomm.merciai@gmail.com>
Cc: Richard Leitner - SKIDATA <Richard.Leitner@skidata.com>,
"linuxfancy@googlegroups.com" <linuxfancy@googlegroups.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: usb251xb: add boost-up property support
Date: Wed, 26 Jan 2022 08:08:48 +0100 [thread overview]
Message-ID: <YfDzgPwhkIpFv+yR@ltleri2> (raw)
In-Reply-To: <20220125214245.GA4196@tom-ThinkPad-T470p>
On Tue, Jan 25, 2022 at 10:42:45PM +0100, Tommaso Merciai wrote:
> On Mon, Jan 24, 2022 at 07:03:57AM +0000, Richard Leitner - SKIDATA wrote:
> > On Sat, Jan 22, 2022 at 12:26:12AM +0100, Tommaso Merciai wrote:
> > >
> > > + if (!of_property_read_u8(np, "boost-up", &property_u8)){
> > > + hub->boost_up = property_u8;
> >
> > IMHO we don't need the property_u8 var here as you could pass
> > &hub->boost_up directly to of_property_read_u8() ?
>
> Hi Richard,
> Thanks for your reply. You mean like:
>
> if (!of_property_read_u8(np, "boost-up", &hub->boost_up))
exactly.
>
> Let me know. I'll fix that in v2.
>
great!
thanks & regards;rl
next prev parent reply other threads:[~2022-01-26 7:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 23:26 [PATCH] usb: usb251xb: add boost-up property support Tommaso Merciai
2022-01-24 7:03 ` Richard Leitner - SKIDATA
2022-01-25 21:42 ` Tommaso Merciai
2022-01-26 7:08 ` Richard Leitner [this message]
2022-01-27 17:53 ` Tommaso Merciai
2022-01-28 15:31 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfDzgPwhkIpFv+yR@ltleri2 \
--to=richard.leitner@linux.dev \
--cc=Richard.Leitner@skidata.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxfancy@googlegroups.com \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox