From: Greg KH <gregkh@linuxfoundation.org>
To: Jack Pham <quic_jackp@quicinc.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Roger Quadros <rogerq@kernel.org>,
Michal Nazarewicz <mina86@mina86.com>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v4] usb: gadget: f_mass_storage: Make CD-ROM emulation work with Mac OS-X
Date: Wed, 26 Jan 2022 13:37:25 +0100 [thread overview]
Message-ID: <YfFAhez1altQSiMq@kroah.com> (raw)
In-Reply-To: <20220126012154.GH3221@jackp-linux.qualcomm.com>
On Tue, Jan 25, 2022 at 05:21:54PM -0800, Jack Pham wrote:
> On Mon, Jan 24, 2022 at 08:01:50AM -0800, Jack Pham wrote:
> > From: Roger Quadros <roger.quadros@nokia.com>
> >
> > Mac OS-X expects CD-ROM TOC in raw format (i.e. format:2). It also
> > sends the READ_TOC CDB in old style SFF8020i format. i.e. 2 format bits
> > are encoded in MSBs of CDB byte 9.
> >
> > This patch will enable CD-ROM emulation to work with Mac OS-X. Tested on
> > Mac OS X v10.6.3.
> >
> > Signed-off-by: Roger Quadros <roger.quadros@nokia.com>
> > Signed-off-by: Jack Pham <quic_jackp@quicinc.com>
> > ---
> > v4: Updated return length as I had inadvertently applied an earlier version of
> > Roger's patch which had the same mistake [2]
>
> Hi Alan, if this looks fine to you would you please mind providing your
> Acked-by again?
>
> Also, if there are no objections, I think this patch can qualify as a
> bugfix and I can send a v5 Cc'ed to stable with a Fixes tag of commit
> d5e2b67aae79 ("USB: g_mass_storage: template f_mass_storage.c file
> created") -- basically this has been around for as long as
> f_mass_storage.c itself (if not even before when CD-ROM emulation was
> first introduced to the former file_storage gadget).
It's a new feature, not a bugfix :)
prev parent reply other threads:[~2022-01-26 12:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 16:01 [PATCH v4] usb: gadget: f_mass_storage: Make CD-ROM emulation work with Mac OS-X Jack Pham
2022-01-26 1:21 ` Jack Pham
2022-01-26 1:51 ` Alan Stern
2022-01-26 12:37 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfFAhez1altQSiMq@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=quic_jackp@quicinc.com \
--cc=rogerq@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).