From: Andrew Lunn <andrew@lunn.ch>
To: Aaron Ma <aaron.ma@canonical.com>
Cc: Mario.Limonciello@amd.com, kuba@kernel.org,
henning.schild@siemens.com, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, hayeswang@realtek.com, tiwai@suse.de
Subject: Re: [PATCH] net: usb: r8152: Add MAC passthrough support for RTL8153BL
Date: Thu, 27 Jan 2022 15:19:31 +0100 [thread overview]
Message-ID: <YfKp81yJWd95Jrg7@lunn.ch> (raw)
In-Reply-To: <20220127100109.12979-1-aaron.ma@canonical.com>
On Thu, Jan 27, 2022 at 06:01:09PM +0800, Aaron Ma wrote:
> RTL8153-BL is used in Lenovo Thunderbolt4 dock.
> Add the support of MAC passthrough.
> This is ported from Realtek Outbox driver r8152.53.56-2.15.0.
>
> There are 2 kinds of rules for MAC passthrough of Lenovo products,
> 1st USB vendor ID belongs to Lenovo, 2nd the chip of RTL8153-BL
> is dedicated for Lenovo. Check the ocp data first then set ACPI object
> names.
>
> Suggested-by: Hayes Wang <hayeswang@realtek.com>
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> ---
> drivers/net/usb/r8152.c | 44 ++++++++++++++++++++++-------------------
> 1 file changed, 24 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index ee41088c5251..df997b330ee4 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -718,6 +718,7 @@ enum spd_duplex {
> #define AD_MASK 0xfee0
> #define BND_MASK 0x0004
> #define BD_MASK 0x0001
> +#define BL_MASK BIT(3)
Just to be sure, this is defined by Realtek? This is not just Lenovo
just misusing a reserved bit?
Andrew
next prev parent reply other threads:[~2022-01-27 14:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 10:01 [PATCH] net: usb: r8152: Add MAC passthrough support for RTL8153BL Aaron Ma
2022-01-27 10:10 ` Greg KH
2022-01-27 10:14 ` Aaron Ma
2022-01-27 11:07 ` Hayes Wang
2022-01-28 4:20 ` Aaron Ma
2022-01-27 14:19 ` Andrew Lunn [this message]
2022-01-28 4:19 ` Aaron Ma
2022-01-28 4:32 ` [PATCH v3] " Aaron Ma
2022-01-28 8:21 ` Henning Schild
2022-01-28 18:06 ` Andrew Lunn
2022-01-28 18:41 ` Limonciello, Mario
2022-01-28 20:20 ` Henning Schild
2022-01-28 20:29 ` Limonciello, Mario
2022-01-28 21:07 ` Henning Schild
2022-02-08 7:15 ` Hayes Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfKp81yJWd95Jrg7@lunn.ch \
--to=andrew@lunn.ch \
--cc=Mario.Limonciello@amd.com \
--cc=aaron.ma@canonical.com \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=henning.schild@siemens.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).