From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Oliver Neukum <oneukum@suse.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v1 1/1] usbnet: add devlink support
Date: Fri, 28 Jan 2022 12:27:06 +0100 [thread overview]
Message-ID: <YfPTCmMDlXD1UHx9@pengutronix.de> (raw)
In-Reply-To: <YfLPvF6pmcL1UG2f@rowland.harvard.edu>
On Thu, Jan 27, 2022 at 12:00:44PM -0500, Alan Stern wrote:
> On Thu, Jan 27, 2022 at 12:13:53PM +0100, Greg KH wrote:
> > On Thu, Jan 27, 2022 at 12:07:42PM +0100, Oleksij Rempel wrote:
> > > The weakest link of usbnet devices is the USB cable.
> >
> > The weakest link of any USB device is the cable, why is this somehow
> > special to usbnet devices?
> >
> > > Currently there is
> > > no way to automatically detect cable related issues except of analyzing
> > > kernel log, which would differ depending on the USB host controller.
> > >
> > > The Ethernet packet counter could potentially show evidence of some USB
> > > related issues, but can be Ethernet related problem as well.
> > >
> > > To provide generic way to detect USB issues or HW issues on different
> > > levels we need to make use of devlink.
> >
> > Please make this generic to all USB devices, usbnet is not special here
> > at all.
>
> Even more basic question: How is the kernel supposed to tell the
> difference between a USB issue and a HW issue? That is, by what
> criterion do you decide which category a particular issue falls under?
In case of networking device, from user space perspective, we have a
communication issue with some external device over the Ethernet.
So, depending on the health state of following chain:
cpu->hcd->USB cable->ethernet_controller->ethernet_cable-<...
We need to decide what to do, and what can be done automatically by
device itself, for example Mars rover :) The user space should get as
much information as possible what's going on in the system, to decide
the proper measures to fix or mitigate the problem. System designers
usually (hopefully) find out during testing what URB status and IP
uplink status for that hardware means and how to fix that.
Regards,
Oleksij & Marc
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-01-28 11:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 11:07 [PATCH net-next v1 1/1] usbnet: add devlink support Oleksij Rempel
2022-01-27 11:13 ` Greg KH
2022-01-27 12:31 ` Oleksij Rempel
2022-01-27 13:22 ` Greg KH
2022-01-28 11:12 ` Oleksij Rempel
2022-01-28 11:23 ` Greg KH
2022-01-28 11:31 ` Oleksij Rempel
2022-02-02 9:14 ` Oliver Neukum
2022-01-27 17:00 ` Alan Stern
2022-01-28 11:27 ` Oleksij Rempel [this message]
2022-01-28 15:33 ` Alan Stern
2022-01-27 11:18 ` Greg KH
2022-01-27 11:19 ` Greg KH
2022-01-27 15:43 ` Andrew Lunn
2022-01-27 16:56 ` Jakub Kicinski
2022-01-27 19:59 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfPTCmMDlXD1UHx9@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).