From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91588C4332F for ; Wed, 16 Feb 2022 19:45:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235417AbiBPTp6 (ORCPT ); Wed, 16 Feb 2022 14:45:58 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:60858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238299AbiBPTpr (ORCPT ); Wed, 16 Feb 2022 14:45:47 -0500 Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EB3F2B0B11 for ; Wed, 16 Feb 2022 11:45:34 -0800 (PST) Received: by mail-oi1-x22e.google.com with SMTP id v25so1893312oiv.2 for ; Wed, 16 Feb 2022 11:45:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=e6yQe3558orWsQDh5OT0ACtDm6j/DudE1IMag6+wpmU=; b=cyEisrUfIYIupzeDc7DssR+Xl1dljHVZGnaXZLOJ0ziRL9XEgpuPaEYsbq7SlI+9ZG Ua5Zl1a6J7kqGWvycX7gvk6s15vhFJ9PFMimaQCl21vgdBChejWxlu8gpQPFAE9i077Y 6woHb+/Pu54ONADW/KcHt9XYwKvRdZjNmkgYuslxYg+6kC/qiS3oDMOLp4iRWVoJ7I45 oY+Rncu3rJRnMxGMeO3CRQWTnSw5H9g3UWfmw3TjntSAukFkDR03YHncuEhAFKTwpbsv CnH8va2j8l1tXNVqLwtOPFNQmGmfFQfD8i7wgpHpP5ZSpDJSvJpbJ76cMSQFvhlG5AVz D7Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e6yQe3558orWsQDh5OT0ACtDm6j/DudE1IMag6+wpmU=; b=sJadTRWFI3tsInB3XOUjg/7koAeKS1Ia/88A1jaFX/zRxhhrPD4n6nggrwY0E0ZR/a MRBtFCbJ7v8yY0vmz5Mp7HTVS9p+Z1vI8CXUtmlg8NPVqFNShMGx2OAi3AkXEK7jttnI U8S84ihDYTl+AC/7blJ/pmfuRilCnZ+D8ujLHhAgtQ+8ODmzYx3B9PO88sOP475pKv6G gfQ0o+hRxPdE6otRVqDO6G/iG2z8TrqVBtX5JHxc6dUQ987YIWdi4UqGMaU3yOut63Lf bqt0wxVVdvNJGJ4qmF7uXg8eFrKPtZB7IhFZnN6WqHI1eySAjU2Rl7EVGrddGB3ce7i3 BGwQ== X-Gm-Message-State: AOAM5327Hw0un7IETJrj/NCM06J82dKwhOLreY9VPZMQ4fN5t6DdZOOQ GhSuZSBV9fYAIeAPQ+F6m2KCkw== X-Google-Smtp-Source: ABdhPJyJlq7VFOgJ7PeIDbfRTtmz7YoxDnNxuFCSIuzLyAfTeNEgRv2wIwMRQjwpbTLb9U0w3eCjWw== X-Received: by 2002:a05:6808:2314:b0:2cd:dc2:3edc with SMTP id bn20-20020a056808231400b002cd0dc23edcmr1395304oib.145.1645040733552; Wed, 16 Feb 2022 11:45:33 -0800 (PST) Received: from yoga (rrcs-97-77-166-58.sw.biz.rr.com. [97.77.166.58]) by smtp.gmail.com with ESMTPSA id c19sm2666744oaq.0.2022.02.16.11.45.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Feb 2022 11:45:33 -0800 (PST) Date: Wed, 16 Feb 2022 13:45:30 -0600 From: Bjorn Andersson To: Greg Kroah-Hartman Cc: Doug Anderson , Matthias Kaehlcke , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , Felipe Balbi , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Krzysztof Kozlowski , Stephen Boyd , Peter Chen , LKML , Roger Quadros , Michal Simek , Linux USB List , Bastien Nocera , Ravi Chandra Sadineni , Andy Gross , linux-arm-msm Subject: Re: [PATCH v20 5/5] arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub Message-ID: References: <20220119204345.3769662-1-mka@chromium.org> <20220119124327.v20.5.Ie0d2c1214b767bb5551dd4cad38398bd40e4466f@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue 15 Feb 12:55 CST 2022, Greg Kroah-Hartman wrote: > On Tue, Feb 15, 2022 at 09:54:54AM -0800, Doug Anderson wrote: > > Hi, > > > > On Tue, Feb 8, 2022 at 11:21 AM Matthias Kaehlcke wrote: > > > > > > On Tue, Feb 08, 2022 at 11:57:20AM +0100, Greg Kroah-Hartman wrote: > > > > On Wed, Jan 19, 2022 at 12:43:45PM -0800, Matthias Kaehlcke wrote: > > > > > Add nodes for the onboard USB hub on trogdor devices. Remove the > > > > > 'always-on' property from the hub regulator, since the regulator > > > > > is now managed by the onboard_usb_hub driver. > > > > > > > > > > Signed-off-by: Matthias Kaehlcke > > > > > Reviewed-by: Stephen Boyd > > > > > Reviewed-by: Douglas Anderson > > > > > --- > > > > > > > > No DT maintainer approval yet? :( > > > > > > Bjorn usually just picks DT changes into the QCOM tree when they are > > > ready, so I wouldn't interpret anything into the lack of an explicit > > > Ack. > > > > Right, so the expectation is that this patch wouldn't land through the > > USB tree but would instead land through the Qualcomm tree, probably a > > revision after the code lands in the USB tree to avoid dependency > > problems. > > But our tools pick up the whole series. I can't just do "i will pick > patches 1-4 only" easily, and neither can any other maintainer. > Most other maintainers uses -P to selectively pick the patches that applies to their subsystem. That said, I really do recognize the inconvenience on your part and the number of patches being sent your way. > Why not just get their ack so that I know it can come through the USB > tree? That's what normally happens for other changes like this where a > driver change is required first. > Because while the change looks good I don't think it's fine to take it through the USB tree - the dts tree typically looks like a shotgun hit across the dts files. And you and I have already seen several times that dts changes do conflict when you take some of them in the USB tree. Unfortunately I see only two ways around this problem, either you start picking selectively or I manage to convince all contributors that they must split their series to keep dts changes separate (which isn't a bad idea in itself). Regards, Bjorn