From: Rob Herring <robh@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Oliver Neukum <oneukum@suse.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v1 4/4] usbnet: add support for label from device tree
Date: Tue, 8 Feb 2022 22:00:16 -0600 [thread overview]
Message-ID: <YgM8UIEfw+UbDwrE@robh.at.kernel.org> (raw)
In-Reply-To: <20220127104905.899341-5-o.rempel@pengutronix.de>
On Thu, Jan 27, 2022 at 11:49:05AM +0100, Oleksij Rempel wrote:
> Similar to the option to set a netdev name in device tree for switch
> ports by using the property "label" in the DSA framework, this patch
> adds this functionality to the usbnet infrastructure.
>
> This will help to name the interfaces properly throughout supported
> devices. This provides stable interface names which are useful
> especially in embedded use cases.
I'll pile on... The purpose of 'label' is to describe a human readable
label on a port of a box. It should otherwise be opaque to s/w. Yes,
there are abuses of that in the kernel, but don't add more.
Rob
next prev parent reply other threads:[~2022-02-09 4:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 10:49 [PATCH net-next v1 0/4] usbnet: add "label" support Oleksij Rempel
2022-01-27 10:49 ` [PATCH net-next v1 1/4] dt-bindings: net: add schema for ASIX USB Ethernet controllers Oleksij Rempel
2022-01-27 10:59 ` Greg KH
2022-02-03 13:21 ` Oliver Neukum
2022-02-09 3:41 ` Rob Herring
2022-01-27 10:49 ` [PATCH net-next v1 2/4] dt-bindings: net: add schema for Microchip/SMSC LAN95xx " Oleksij Rempel
2022-01-27 10:59 ` Greg KH
2022-01-27 11:28 ` Oleksij Rempel
2022-02-09 3:47 ` Rob Herring
2022-01-27 14:03 ` Rob Herring
2022-01-27 10:49 ` [PATCH net-next v1 3/4] dt-bindings: net: add "label" property for all usbnet " Oleksij Rempel
2022-02-09 3:51 ` Rob Herring
2022-01-27 10:49 ` [PATCH net-next v1 4/4] usbnet: add support for label from device tree Oleksij Rempel
2022-01-27 10:57 ` Greg KH
2022-01-27 11:23 ` Oleksij Rempel
2022-01-27 11:30 ` Greg KH
2022-01-27 12:00 ` Oleksij Rempel
2022-01-27 13:21 ` Greg KH
2022-01-27 14:01 ` Lucas Stach
2022-02-03 0:12 ` Sergey Ryazanov
2022-02-03 2:20 ` Sergey Ryazanov
2022-02-03 13:04 ` Andrew Lunn
2022-02-03 14:20 ` Greg KH
2022-01-27 14:28 ` Andrew Lunn
2022-02-09 4:00 ` Rob Herring [this message]
2022-01-27 10:57 ` [PATCH net-next v1 0/4] usbnet: add "label" support Greg KH
2022-02-03 9:34 ` Oliver Neukum
2022-02-03 10:27 ` Oleksij Rempel
2022-02-03 13:16 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgM8UIEfw+UbDwrE@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).