From: Greg KH <gregkh@linuxfoundation.org>
To: 3090101217@zju.edu.cn
Cc: balbi@kernel.org, jleng@ambarella.com,
laurent.pinchart@ideasonboard.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] usb: gadget: f_uvc: fix superspeedplus transfer
Date: Tue, 15 Feb 2022 15:07:02 +0100 [thread overview]
Message-ID: <Yguzht2JJtF+8N76@kroah.com> (raw)
In-Reply-To: <20220215021647.4316-1-3090101217@zju.edu.cn>
On Tue, Feb 15, 2022 at 10:16:47AM +0800, 3090101217@zju.edu.cn wrote:
> From: Jing Leng <jleng@ambarella.com>
>
> UVC driver doesn't set ssp_descriptors in struct usb_function,
> If UVC uses superspeedplus UDC (e.g. cdnsp), when
> config_ep_by_speed_and_alt is called, the g->speed is
> USB_SPEED_SUPER_PLUS, and f->ssp_descriptors is NULL,
> So kernel will access NULL pointer of speed_desc.
>
> Call trace:
> config_ep_by_speed_and_alt+0x3c/0x2a0 [libcomposite]
> uvc_function_set_alt+0xd4/0x2e8 [usb_f_uvc]
> set_config.constprop.0+0x154/0x3a0 [libcomposite]
> composite_setup+0x314/0xb44 [libcomposite]
> configfs_composite_setup+0x84/0xb0 [libcomposite]
> cdnsp_ep0_std_request+0x25c/0x470 [cdns3]
> cdnsp_setup_analyze+0x94/0x25c [cdns3]
> cdnsp_handle_event+0xe8/0x23c [cdns3]
> cdnsp_thread_irq_handler+0x58/0xe8 [cdns3]
> irq_thread_fn+0x2c/0xa0
> irq_thread+0x164/0x280
> kthread+0x128/0x134
> ret_from_fork+0x10/0x40
What does "call trace" here mean? Is this an error? Something else?
>
> Signed-off-by: Jing Leng <jleng@ambarella.com>
> ---
> drivers/usb/gadget/function/f_uvc.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
You did not read the information that my bot told you to read, for how
to properly version your patches :(
Please go back and do so when you resend all of them.
Also this is not a patch series? Why not?
thanks,
greg k-h
next prev parent reply other threads:[~2022-02-15 14:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 5:52 [PATCH] usb: gadget: f_uvc: fix superspeedplus transfer 3090101217
2022-02-14 10:37 ` Greg KH
2022-02-15 2:16 ` [PATCH v2] " 3090101217
2022-02-15 14:07 ` Greg KH [this message]
2022-02-16 2:34 ` 冷静
2022-02-16 10:39 ` Greg KH
2022-02-17 2:57 ` Jing Leng
2022-02-17 3:10 ` [PATCH v3] usb: gadget: f_uvc: add superspeed plus transfer support 3090101217
2022-11-03 6:00 ` [PATCH v4] usb: gadget: f_uvc: add super speed " Jing Leng
[not found] ` <166746992763.2442643.8937261146141591391@Monstersaurus>
2022-11-03 10:39 ` [EXT] " Jing Leng
2022-11-03 13:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yguzht2JJtF+8N76@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=3090101217@zju.edu.cn \
--cc=balbi@kernel.org \
--cc=jleng@ambarella.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).