[PATCH v1] usb: hcd: Try MSI interrupts on PCI devices

[PATCH v1] usb: hcd: Try MSI interrupts on PCI devices

[Andy Shevchenko]

It appears that some platforms share same IRQ line between several devices,
some of which are EHCI and OHCI controllers. This is neither practical nor
performance-wise, especially in the case when they are supporting MSI.

In order to improve the situation try to allocate MSI and fallback to legacy
IRQ if no MSI available.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/usb/core/hcd-pci.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c
index 1547aa6e5314..4dc443aaef5c 100644
--- a/drivers/usb/core/hcd-pci.c
+++ b/drivers/usb/core/hcd-pci.c
@@ -194,20 +194,21 @@ int usb_hcd_pci_probe(struct pci_dev *dev, const struct pci_device_id *id,
 	 * make sure irq setup is not touched for xhci in generic hcd code
 	 */
 	if ((driver->flags & HCD_MASK) < HCD_USB3) {
-		if (!dev->irq) {
+		retval = pci_alloc_irq_vectors(dev, 1, 1, PCI_IRQ_LEGACY | PCI_IRQ_MSI);
+		if (retval < 0) {
 			dev_err(&dev->dev,
 			"Found HC with no IRQ. Check BIOS/PCI %s setup!\n",
 				pci_name(dev));
 			retval = -ENODEV;
 			goto disable_pci;
 		}
-		hcd_irq = dev->irq;
+		hcd_irq = pci_irq_vector(dev, 0);
 	}
 
 	hcd = usb_create_hcd(driver, &dev->dev, pci_name(dev));
 	if (!hcd) {
 		retval = -ENOMEM;
-		goto disable_pci;
+		goto free_irq_vectors;
 	}
 
 	hcd->amd_resume_bug = (usb_hcd_amd_remote_wakeup_quirk(dev) &&
@@ -286,6 +287,9 @@ int usb_hcd_pci_probe(struct pci_dev *dev, const struct pci_device_id *id,
 
 put_hcd:
 	usb_put_hcd(hcd);
+free_irq_vectors:
+	if ((driver->flags & HCD_MASK) < HCD_USB3)
+		pci_free_irq_vectors(dev);
 disable_pci:
 	pci_disable_device(dev);
 	dev_err(&dev->dev, "init %s fail, %d\n", pci_name(dev), retval);
@@ -343,6 +347,8 @@ void usb_hcd_pci_remove(struct pci_dev *dev)
 		up_read(&companions_rwsem);
 	}
 	usb_put_hcd(hcd);
+	if ((hcd->driver->flags & HCD_MASK) < HCD_USB3)
+		pci_free_irq_vectors(dev);
 	pci_disable_device(dev);
 }
 EXPORT_SYMBOL_GPL(usb_hcd_pci_remove);
@@ -454,7 +460,7 @@ static int suspend_common(struct device *dev, bool do_wakeup)
 	 * synchronized here.
 	 */
 	if (!hcd->msix_enabled)
-		synchronize_irq(pci_dev->irq);
+		synchronize_irq(pci_irq_vector(pci_dev, 0));
 
 	/* Downstream ports from this root hub should already be quiesced, so
 	 * there will be no DMA activity.  Now we can shut down the upstream
-- 
2.27.0

Re: [PATCH v1] usb: hcd: Try MSI interrupts on PCI devices

[micklorain]

Hi,

This patch breaks USB for me. I noticed when I upgraded from debian's 4.19.0-18 (working) to 5.10.0-10 (broken). I git bisect'ed until I found that this patch is the culprit. Upstream 5.17.0-rc2 is still broken, but 5.17.0-rc2 with this patch reverted works.

lsusb when things work :
https://paste.debian.net/hidden/2a964425/

lsusb when things are broken :
https://paste.debian.net/hidden/0376920c/

dmesg when things are broken :
https://paste.debian.net/hidden/780ca112/

dmesg when things work :
https://paste.debian.net/hidden/4d1bfc0f/

Let me know if you need anything else from me.

Thanks !
Mick Lorain

-------- Original Message --------

On 02/07/2020 16:30, Andy Shevchenko wrote:

> It appears that some platforms share same IRQ line between several devices,
> some of which are EHCI and OHCI controllers. This is neither practical nor
> performance-wise, especially in the case when they are supporting MSI.
>
> In order to improve the situation try to allocate MSI and fallback to legacy
> IRQ if no MSI available.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/usb/core/hcd-pci.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c
> index 1547aa6e5314..4dc443aaef5c 100644
> --- a/drivers/usb/core/hcd-pci.c
> +++ b/drivers/usb/core/hcd-pci.c
> @@ -194,20 +194,21 @@ int usb_hcd_pci_probe(struct pci_dev *dev, const struct pci_device_id *id,
>  	 * make sure irq setup is not touched for xhci in generic hcd code
>  	 */
>  	if ((driver->flags & HCD_MASK) < HCD_USB3) {
> -		if (!dev->irq) {
> +		retval = pci_alloc_irq_vectors(dev, 1, 1, PCI_IRQ_LEGACY | PCI_IRQ_MSI);
> +		if (retval < 0) {
>  			dev_err(&dev->dev,
>  			"Found HC with no IRQ. Check BIOS/PCI %s setup!\n",
>  				pci_name(dev));
>  			retval = -ENODEV;
>  			goto disable_pci;
>  		}
> -		hcd_irq = dev->irq;
> +		hcd_irq = pci_irq_vector(dev, 0);
>  	}
>
>  	hcd = usb_create_hcd(driver, &dev->dev, pci_name(dev));
>  	if (!hcd) {
>  		retval = -ENOMEM;
> -		goto disable_pci;
> +		goto free_irq_vectors;
>  	}
>
>  	hcd->amd_resume_bug = (usb_hcd_amd_remote_wakeup_quirk(dev) &&
> @@ -286,6 +287,9 @@ int usb_hcd_pci_probe(struct pci_dev *dev, const struct pci_device_id *id,
>
>  put_hcd:
>  	usb_put_hcd(hcd);
> +free_irq_vectors:
> +	if ((driver->flags & HCD_MASK) < HCD_USB3)
> +		pci_free_irq_vectors(dev);
>  disable_pci:
>  	pci_disable_device(dev);
>  	dev_err(&dev->dev, "init %s fail, %d\n", pci_name(dev), retval);
> @@ -343,6 +347,8 @@ void usb_hcd_pci_remove(struct pci_dev *dev)
>  		up_read(&companions_rwsem);
>  	}
>  	usb_put_hcd(hcd);
> +	if ((hcd->driver->flags & HCD_MASK) < HCD_USB3)
> +		pci_free_irq_vectors(dev);
>  	pci_disable_device(dev);
>  }
>  EXPORT_SYMBOL_GPL(usb_hcd_pci_remove);
> @@ -454,7 +460,7 @@ static int suspend_common(struct device *dev, bool do_wakeup)
>  	 * synchronized here.
>  	 */
>  	if (!hcd->msix_enabled)
> -		synchronize_irq(pci_dev->irq);
> +		synchronize_irq(pci_irq_vector(pci_dev, 0));
>
>  	/* Downstream ports from this root hub should already be quiesced, so
>  	 * there will be no DMA activity.  Now we can shut down the upstream
> --
> 2.27.0

Re: [PATCH v1] usb: hcd: Try MSI interrupts on PCI devices

[gregkh]

On Mon, Feb 28, 2022 at 08:12:47PM +0000, micklorain wrote:
> Hi,
> 
> This patch breaks USB for me. I noticed when I upgraded from debian's 4.19.0-18 (working) to 5.10.0-10 (broken). I git bisect'ed until I found that this patch is the culprit. Upstream 5.17.0-rc2 is still broken, but 5.17.0-rc2 with this patch reverted works.
> 
> lsusb when things work :
> https://paste.debian.net/hidden/2a964425/
> 
> lsusb when things are broken :
> https://paste.debian.net/hidden/0376920c/
> 
> dmesg when things are broken :
> https://paste.debian.net/hidden/780ca112/

This dmesg says:
	[    1.049161] PCI: Using host bridge windows from ACPI; if necessary, use "pci=nocrs" and report a bug
have you tried that?

> 
> dmesg when things work :
> https://paste.debian.net/hidden/4d1bfc0f/

The messages here look different for PCI, can you diff them?

I see:
[    0.342113] PCI: PCI BIOS area is rw and x. Use pci=nobios if you want it NX.
[    0.342178] PCI: PCI BIOS revision 3.00 entry at 0xf0031, last bus=3
[    0.342180] PCI: Using configuration type 1 for base access

That's not in the "failing" system, are you sure that's the only change
here?

thanks,

greg k-h

Re: [PATCH v1] usb: hcd: Try MSI interrupts on PCI devices

[andriy.shevchenko]

On Mon, Feb 28, 2022 at 08:12:47PM +0000, micklorain wrote:
> Hi,
> 
> This patch breaks USB for me. I noticed when I upgraded from debian's 4.19.0-18 (working) to 5.10.0-10 (broken). I git bisect'ed until I found that this patch is the culprit. Upstream 5.17.0-rc2 is still broken, but 5.17.0-rc2 with this patch reverted works.
> 
> lsusb when things work :
> https://paste.debian.net/hidden/2a964425/
> 
> lsusb when things are broken :
> https://paste.debian.net/hidden/0376920c/
> 
> dmesg when things are broken :
> https://paste.debian.net/hidden/780ca112/
> 
> dmesg when things work :
> https://paste.debian.net/hidden/4d1bfc0f/
> 
> Let me know if you need anything else from me.

Thanks for your report!

Last time I have got something similar it becomes that PCI bridge which is used
to connect USB controller to the PCI Root Bridge was not capable of MSI, while
advertising that capability. I.o.w. HW bug.

To understand if it's something similar, please run (under the root) each of
the following commands:

	lspci -nk -vvv
	cat /proc/interrupts

in both cases, i.e. working and non-working.

And then share the output (all 4 files).

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1] usb: hcd: Try MSI interrupts on PCI devices

[micklorain]

------- Original Message -------

On Monday, February 28th, 2022 at 21:59, andriy.shevchenko@linux.intel.com <andriy.shevchenko@linux.intel.com> wrote:

> On Mon, Feb 28, 2022 at 08:12:47PM +0000, micklorain wrote:
>
> > Hi,
> >
> > This patch breaks USB for me. I noticed when I upgraded from debian's 4.19.0-18 (working) to 5.10.0-10 (broken). I git bisect'ed until I found that this patch is the culprit. Upstream 5.17.0-rc2 is still broken, but 5.17.0-rc2 with this patch reverted works.
> >
> > lsusb when things work :
> >
> > https://paste.debian.net/hidden/2a964425/
> >
> > lsusb when things are broken :
> >
> > https://paste.debian.net/hidden/0376920c/
> >
> > dmesg when things are broken :
> >
> > https://paste.debian.net/hidden/780ca112/
> >
> > dmesg when things work :
> >
> > https://paste.debian.net/hidden/4d1bfc0f/
> >
> > Let me know if you need anything else from me.
>
> Thanks for your report!
>
> Last time I have got something similar it becomes that PCI bridge which is used
>
> to connect USB controller to the PCI Root Bridge was not capable of MSI, while
>
> advertising that capability. I.o.w. HW bug.
>
> To understand if it's something similar, please run (under the root) each of
>
> the following commands:
>
> lspci -nk -vvv
>
> cat /proc/interrupts
>
> in both cases, i.e. working and non-working.
>
> And then share the output (all 4 files).
>
> --
>
> With Best Regards,
>
> Andy Shevchenko

Hi,

Thanks for your reply.
This is the results of the commands you requested :

* When things work (commit dcb85f85fa6f142aae1fe86f399d4503d49f2b60 with commit 306c54d0edb6ba94d39877524dddebaad7770cf2 reverted)
- lspci -nk -vvv :
https://paste.debian.net/hidden/77d92dc9/

- cat /proc/interrupts
https://paste.debian.net/hidden/67208c8e/

* When things are broken (commit dcb85f85fa6f142aae1fe86f399d4503d49f2b60)
- lspci -nk -vvv :
https://paste.debian.net/hidden/121362b3/

- cat /proc/interrupts :
https://paste.debian.net/hidden/dbe8d1bb/

Hope this can help.

Thanks.
Mick Lorain

Re: [PATCH v1] usb: hcd: Try MSI interrupts on PCI devices

[andriy.shevchenko]

On Sun, Mar 06, 2022 at 04:09:49PM +0000, micklorain wrote:
> On Monday, February 28th, 2022 at 21:59, andriy.shevchenko@linux.intel.com <andriy.shevchenko@linux.intel.com> wrote:
> > On Mon, Feb 28, 2022 at 08:12:47PM +0000, micklorain wrote:

...

> > Last time I have got something similar it becomes that PCI bridge which is used
> >
> > to connect USB controller to the PCI Root Bridge was not capable of MSI, while
> >
> > advertising that capability. I.o.w. HW bug.
> >
> > To understand if it's something similar, please run (under the root) each of
> >
> > the following commands:
> >
> > lspci -nk -vvv
> >
> > cat /proc/interrupts
> >
> > in both cases, i.e. working and non-working.
> >
> > And then share the output (all 4 files).

> Thanks for your reply.
> This is the results of the commands you requested :
> 
> * When things work (commit dcb85f85fa6f142aae1fe86f399d4503d49f2b60 with commit 306c54d0edb6ba94d39877524dddebaad7770cf2 reverted)
> - lspci -nk -vvv :
> https://paste.debian.net/hidden/77d92dc9/
> 
> - cat /proc/interrupts
> https://paste.debian.net/hidden/67208c8e/
> 
> * When things are broken (commit dcb85f85fa6f142aae1fe86f399d4503d49f2b60)
> - lspci -nk -vvv :
> https://paste.debian.net/hidden/121362b3/
> 
> - cat /proc/interrupts :
> https://paste.debian.net/hidden/dbe8d1bb/
> 
> Hope this can help.

Thank you for sharing. Are you able to compile a kernel and boot it? If so,
can you try the following patch?

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 65f7f6b0576c..149742aa5f4d 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -3041,6 +3041,13 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_BROADCOM,
 			PCI_DEVICE_ID_TIGON3_5715S,
 			quirk_msi_intx_disable_bug);
 
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4386, quirk_msi_intx_disable_ati_bug);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4387, quirk_msi_intx_disable_ati_bug);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4388, quirk_msi_intx_disable_ati_bug);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4389, quirk_msi_intx_disable_ati_bug);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x438a, quirk_msi_intx_disable_ati_bug);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x438b, quirk_msi_intx_disable_ati_bug);
+
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4390,
 			quirk_msi_intx_disable_ati_bug);
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4391,


In case it doesn't help, remove 'ati_' part from the function name and try again.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1] usb: hcd: Try MSI interrupts on PCI devices

[micklorain]

Hello,

On Wednesday, March 9th, 2022 at 18:47, andriy.shevchenko@linux.intel.com <andriy.shevchenko@linux.intel.com> wrote:

> On Sun, Mar 06, 2022 at 04:09:49PM +0000, micklorain wrote:
>
> > On Monday, February 28th, 2022 at 21:59, andriy.shevchenko@linux.intel.com andriy.shevchenko@linux.intel.com wrote:
> >
> > > On Mon, Feb 28, 2022 at 08:12:47PM +0000, micklorain wrote:
>
> ...
>
> > > Last time I have got something similar it becomes that PCI bridge which is used
> > >
> > > to connect USB controller to the PCI Root Bridge was not capable of MSI, while
> > >
> > > advertising that capability. I.o.w. HW bug.
> > >
> > > To understand if it's something similar, please run (under the root) each of
> > >
> > > the following commands:
> > >
> > > lspci -nk -vvv
> > >
> > > cat /proc/interrupts
> > >
> > > in both cases, i.e. working and non-working.
> > >
> > > And then share the output (all 4 files).
>
> > Thanks for your reply.
> >
> > This is the results of the commands you requested :
> >
> > * When things work (commit dcb85f85fa6f142aae1fe86f399d4503d49f2b60 with commit 306c54d0edb6ba94d39877524dddebaad7770cf2 reverted)
> >
> > - lspci -nk -vvv :
> >
> > https://paste.debian.net/hidden/77d92dc9/
> >
> > - cat /proc/interrupts
> >
> > https://paste.debian.net/hidden/67208c8e/
> >
> > * When things are broken (commit dcb85f85fa6f142aae1fe86f399d4503d49f2b60)
> >
> > - lspci -nk -vvv :
> >
> > https://paste.debian.net/hidden/121362b3/
> >
> > - cat /proc/interrupts :
> >
> > https://paste.debian.net/hidden/dbe8d1bb/
> >
> > Hope this can help.
>
> Thank you for sharing. Are you able to compile a kernel and boot it? If so,
>
> can you try the following patch?

I tried the patch, but it didn't help...

>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
>
> index 65f7f6b0576c..149742aa5f4d 100644
>
> --- a/drivers/pci/quirks.c
>
> +++ b/drivers/pci/quirks.c
>
> @@ -3041,6 +3041,13 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_BROADCOM,
>
> PCI_DEVICE_ID_TIGON3_5715S,
>
> quirk_msi_intx_disable_bug);
>
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4386, quirk_msi_intx_disable_ati_bug);
>
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4387, quirk_msi_intx_disable_ati_bug);
>
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4388, quirk_msi_intx_disable_ati_bug);
>
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4389, quirk_msi_intx_disable_ati_bug);
>
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x438a, quirk_msi_intx_disable_ati_bug);
>
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x438b, quirk_msi_intx_disable_ati_bug);
>
> +
>
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4390,
>
> quirk_msi_intx_disable_ati_bug);
>
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4391,
>
> In case it doesn't help, remove 'ati_' part from the function name and try again.

... but removing 'ati_' from the function name indeed fixed my issue.

Will this fix be upstreamed now ?

Thank you very much for your help.

Mick Lorain

Re: [PATCH v1] usb: hcd: Try MSI interrupts on PCI devices

[micklorain]

Hi,
Thanks for taking the time to reply.

------- Original Message -------

On Monday, February 28th, 2022 at 21:27, gregkh@linuxfoundation.org <gregkh@linuxfoundation.org> wrote:

> On Mon, Feb 28, 2022 at 08:12:47PM +0000, micklorain wrote:
>
> > Hi,
> >
> > This patch breaks USB for me. I noticed when I upgraded from debian's 4.19.0-18 (working) to 5.10.0-10 (broken). I git bisect'ed until I found that this patch is the culprit. Upstream 5.17.0-rc2 is still broken, but 5.17.0-rc2 with this patch reverted works.
> >
> > lsusb when things work :
> >
> > https://paste.debian.net/hidden/2a964425/
> >
> > lsusb when things are broken :
> >
> > https://paste.debian.net/hidden/0376920c/
> >
> > dmesg when things are broken :
> >
> > https://paste.debian.net/hidden/780ca112/
>
> This dmesg says:
>
> [ 1.049161] PCI: Using host bridge windows from ACPI; if necessary, use "pci=nocrs" and report a bug
>
> have you tried that?

I tried to use "pci=nocrs", but it didn't help.

>
> > dmesg when things work :
> >
> > https://paste.debian.net/hidden/4d1bfc0f/
>
> The messages here look different for PCI, can you diff them?
>
> I see:
>
> [ 0.342113] PCI: PCI BIOS area is rw and x. Use pci=nobios if you want it NX.
>
> [ 0.342178] PCI: PCI BIOS revision 3.00 entry at 0xf0031, last bus=3
>
> [ 0.342180] PCI: Using configuration type 1 for base access
>
> That's not in the "failing" system, are you sure that's the only change
>
> here?

Sorry, my email wasn't very clear, I gave the dmesg for two very different kernel versions.

But anyway, it doesn't really matter since Andriy Shevchenko found the problem.

Again, thank you for your time.

Mick Lorain

Re: [PATCH v1] usb: hcd: Try MSI interrupts on PCI devices

[andriy.shevchenko]

On Sun, Mar 13, 2022 at 09:44:36PM +0000, micklorain wrote:
> On Wednesday, March 9th, 2022 at 18:47, andriy.shevchenko@linux.intel.com <andriy.shevchenko@linux.intel.com> wrote:
> > On Sun, Mar 06, 2022 at 04:09:49PM +0000, micklorain wrote:
> > > On Monday, February 28th, 2022 at 21:59, andriy.shevchenko@linux.intel.com andriy.shevchenko@linux.intel.com wrote:
> > > > On Mon, Feb 28, 2022 at 08:12:47PM +0000, micklorain wrote:

> > ...
> >
> > > > Last time I have got something similar it becomes that PCI bridge which is used
> > > >
> > > > to connect USB controller to the PCI Root Bridge was not capable of MSI, while
> > > >
> > > > advertising that capability. I.o.w. HW bug.
> > > >
> > > > To understand if it's something similar, please run (under the root) each of
> > > >
> > > > the following commands:
> > > >
> > > > lspci -nk -vvv
> > > >
> > > > cat /proc/interrupts
> > > >
> > > > in both cases, i.e. working and non-working.
> > > >
> > > > And then share the output (all 4 files).
> >
> > > Thanks for your reply.
> > >
> > > This is the results of the commands you requested :
> > >
> > > * When things work (commit dcb85f85fa6f142aae1fe86f399d4503d49f2b60 with commit 306c54d0edb6ba94d39877524dddebaad7770cf2 reverted)
> > >
> > > - lspci -nk -vvv :
> > >
> > > https://paste.debian.net/hidden/77d92dc9/
> > >
> > > - cat /proc/interrupts
> > >
> > > https://paste.debian.net/hidden/67208c8e/
> > >
> > > * When things are broken (commit dcb85f85fa6f142aae1fe86f399d4503d49f2b60)
> > >
> > > - lspci -nk -vvv :
> > >
> > > https://paste.debian.net/hidden/121362b3/
> > >
> > > - cat /proc/interrupts :
> > >
> > > https://paste.debian.net/hidden/dbe8d1bb/
> > >
> > > Hope this can help.
> >
> > Thank you for sharing. Are you able to compile a kernel and boot it? If so,
> >
> > can you try the following patch?
> 
> I tried the patch, but it didn't help...
> 
> >
> > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> >
> > index 65f7f6b0576c..149742aa5f4d 100644
> >
> > --- a/drivers/pci/quirks.c
> >
> > +++ b/drivers/pci/quirks.c
> >
> > @@ -3041,6 +3041,13 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_BROADCOM,
> >
> > PCI_DEVICE_ID_TIGON3_5715S,
> >
> > quirk_msi_intx_disable_bug);
> >
> > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4386, quirk_msi_intx_disable_ati_bug);
> >
> > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4387, quirk_msi_intx_disable_ati_bug);
> >
> > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4388, quirk_msi_intx_disable_ati_bug);
> >
> > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4389, quirk_msi_intx_disable_ati_bug);
> >
> > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x438a, quirk_msi_intx_disable_ati_bug);
> >
> > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x438b, quirk_msi_intx_disable_ati_bug);
> >
> > +
> >
> > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4390,
> >
> > quirk_msi_intx_disable_ati_bug);
> >
> > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x4391,
> >
> > In case it doesn't help, remove 'ati_' part from the function name and try again.
> 
> ... but removing 'ati_' from the function name indeed fixed my issue.
> 
> Will this fix be upstreamed now ?

I will do it ASAP. Thanks for report and testing!

-- 
With Best Regards,
Andy Shevchenko