From: Alan Stern <stern@rowland.harvard.edu>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Adam Cozzette <acozzette@cs.hmc.edu>,
linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] USB: storage: ums-realtek: fix error code in rts51x_read_mem()
Date: Fri, 4 Mar 2022 09:18:09 -0500 [thread overview]
Message-ID: <YiIfoU7vVIf6Bbrz@rowland.harvard.edu> (raw)
In-Reply-To: <20220304073504.GA26464@kili>
On Fri, Mar 04, 2022 at 10:35:04AM +0300, Dan Carpenter wrote:
> The rts51x_read_mem() function should return negative error codes.
> Currently if the kmalloc() fails it returns USB_STOR_TRANSPORT_ERROR (3)
> which is treated as success by the callers.
>
> Fixes: 065e60964e29 ("ums_realtek: do not use stack memory for DMA")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Acked-by: Alan Stern <stern@rowland.harvard.edu>
> drivers/usb/storage/realtek_cr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c
> index 3789698d9d3c..0c423916d7bf 100644
> --- a/drivers/usb/storage/realtek_cr.c
> +++ b/drivers/usb/storage/realtek_cr.c
> @@ -365,7 +365,7 @@ static int rts51x_read_mem(struct us_data *us, u16 addr, u8 *data, u16 len)
>
> buf = kmalloc(len, GFP_NOIO);
> if (buf == NULL)
> - return USB_STOR_TRANSPORT_ERROR;
> + return -ENOMEM;
>
> usb_stor_dbg(us, "addr = 0x%x, len = %d\n", addr, len);
>
> --
> 2.20.1
>
prev parent reply other threads:[~2022-03-04 14:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 7:35 [PATCH] USB: storage: ums-realtek: fix error code in rts51x_read_mem() Dan Carpenter
2022-03-04 14:18 ` Alan Stern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiIfoU7vVIf6Bbrz@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=acozzette@cs.hmc.edu \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox