From: Alan Stern <stern@rowland.harvard.edu>
To: syzbot <syzbot+f0fae482604e6d9a87c9@syzkaller.appspotmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, pavel.hofman@ivitera.com,
rob@robgreener.com, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] memory leak in usb_get_configuration
Date: Fri, 11 Mar 2022 16:01:40 -0500 [thread overview]
Message-ID: <Yiu4tCONfHVH1Qfv@rowland.harvard.edu> (raw)
In-Reply-To: <000000000000351b8605d9d1d1bf@google.com>
On Wed, Mar 09, 2022 at 03:54:24PM -0800, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit: 0014404f9c18 Merge branch 'akpm' (patches from Andrew)
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=15864216700000
> kernel config: https://syzkaller.appspot.com/x/.config?x=3f0a704147ec8e32
> dashboard link: https://syzkaller.appspot.com/bug?extid=f0fae482604e6d9a87c9
> compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=13a63dbe700000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10e150a1700000
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+f0fae482604e6d9a87c9@syzkaller.appspotmail.com
>
> BUG: memory leak
> unreferenced object 0xffff88810c0289e0 (size 32):
> comm "kworker/1:2", pid 139, jiffies 4294947862 (age 15.910s)
> hex dump (first 32 bytes):
> 09 02 12 00 01 00 00 00 00 09 04 00 00 00 d0 bb ................
> 3a 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 :...............
> backtrace:
> [<ffffffff82c98127>] kmalloc include/linux/slab.h:586 [inline]
> [<ffffffff82c98127>] usb_get_configuration+0x1c7/0x1cd0 drivers/usb/core/config.c:919
> [<ffffffff82c863f9>] usb_enumerate_device drivers/usb/core/hub.c:2398 [inline]
> [<ffffffff82c863f9>] usb_new_device+0x1a9/0x2e0 drivers/usb/core/hub.c:2536
> [<ffffffff82c88ea4>] hub_port_connect drivers/usb/core/hub.c:5358 [inline]
> [<ffffffff82c88ea4>] hub_port_connect_change drivers/usb/core/hub.c:5502 [inline]
> [<ffffffff82c88ea4>] port_event drivers/usb/core/hub.c:5660 [inline]
> [<ffffffff82c88ea4>] hub_event+0x1364/0x21a0 drivers/usb/core/hub.c:5742
> [<ffffffff8126a41f>] process_one_work+0x2bf/0x600 kernel/workqueue.c:2307
> [<ffffffff8126ad49>] worker_thread+0x59/0x5b0 kernel/workqueue.c:2454
> [<ffffffff81274705>] kthread+0x125/0x160 kernel/kthread.c:377
> [<ffffffff810021ef>] ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295
The console log shows that this is connected to gspca_dev_probe. Let's
see who's calling it...
Alan Stern
#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/ 0014404f9c18
Index: usb-devel/drivers/media/usb/gspca/gspca.c
===================================================================
--- usb-devel.orig/drivers/media/usb/gspca/gspca.c
+++ usb-devel/drivers/media/usb/gspca/gspca.c
@@ -1599,6 +1599,7 @@ int gspca_dev_probe(struct usb_interface
if (dev->descriptor.bNumConfigurations != 1) {
pr_err("%04x:%04x too many config\n",
id->idVendor, id->idProduct);
+ dump_stack();
return -ENODEV;
}
next prev parent reply other threads:[~2022-03-11 22:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 23:54 [syzbot] memory leak in usb_get_configuration syzbot
2022-03-10 9:51 ` Oliver Neukum
2022-03-10 14:36 ` syzbot
2022-03-10 15:29 ` Alan Stern
2022-03-10 11:07 ` Oliver Neukum
2022-03-10 11:07 ` syzbot
2022-03-11 21:01 ` Alan Stern [this message]
2022-03-11 21:10 ` syzbot
2022-03-12 15:08 ` Pavel Skripkin
2022-03-12 15:25 ` Alan Stern
2022-03-12 15:45 ` Pavel Skripkin
2022-03-12 16:02 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yiu4tCONfHVH1Qfv@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pavel.hofman@ivitera.com \
--cc=rob@robgreener.com \
--cc=syzbot+f0fae482604e6d9a87c9@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).