Re: [PATCH 4/5] usb: gadget: uvc: call uvc uvcg_warn on completed status instead of uvcg_info

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Michael,

Thank you for the patch.

On Sun, Apr 03, 2022 at 01:39:13AM +0200, Michael Grzeschik wrote:
> Likewise to the uvcvideo hostside driver, this patch is changing the
> usb_request message of an non zero completion handler call from dev_info
> to dev_warn.
> 
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/usb/gadget/function/uvc_video.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/function/uvc_video.c b/drivers/usb/gadget/function/uvc_video.c
> index b1075e23a61010..8b3116d48d2bd8 100644
> --- a/drivers/usb/gadget/function/uvc_video.c
> +++ b/drivers/usb/gadget/function/uvc_video.c
> @@ -258,7 +258,7 @@ uvc_video_complete(struct usb_ep *ep, struct usb_request *req)
>  		break;
>  
>  	default:
> -		uvcg_info(&video->uvc->func,
> +		uvcg_warn(&video->uvc->func,
>  			  "VS request completed with status %d.\n",
>  			  req->status);
>  		uvcg_queue_cancel(queue, 0);

-- 
Regards,

Laurent Pinchart