* [PATCH] phy: ti: tusb1210: Make tusb1210_chg_det_states static
@ 2022-04-11 13:54 Hans de Goede
2022-04-11 14:40 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2022-04-11 13:54 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Hans de Goede, linux-phy, linux-usb, kernel test robot
Make tusb1210_chg_det_states static, fixing the following sparse warning:
drivers/phy/ti/phy-tusb1210.c:158:12: sparse: sparse:
symbol 'tusb1210_chg_det_states' was not declared. Should it be static?
Fixes: 48969a5623ed ("phy: ti: tusb1210: Add charger detection")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/phy/ti/phy-tusb1210.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/ti/phy-tusb1210.c b/drivers/phy/ti/phy-tusb1210.c
index a0cdbcadf09e..c5bd74874f73 100644
--- a/drivers/phy/ti/phy-tusb1210.c
+++ b/drivers/phy/ti/phy-tusb1210.c
@@ -155,7 +155,7 @@ static int tusb1210_set_mode(struct phy *phy, enum phy_mode mode, int submode)
}
#ifdef CONFIG_POWER_SUPPLY
-const char * const tusb1210_chg_det_states[] = {
+static const char * const tusb1210_chg_det_states[] = {
"CHG_DET_CONNECTING",
"CHG_DET_START_DET",
"CHG_DET_READ_DET",
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] phy: ti: tusb1210: Make tusb1210_chg_det_states static
2022-04-11 13:54 [PATCH] phy: ti: tusb1210: Make tusb1210_chg_det_states static Hans de Goede
@ 2022-04-11 14:40 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2022-04-11 14:40 UTC (permalink / raw)
To: Hans de Goede
Cc: Kishon Vijay Abraham I, linux-phy, linux-usb, kernel test robot
On 11-04-22, 15:54, Hans de Goede wrote:
> Make tusb1210_chg_det_states static, fixing the following sparse warning:
>
> drivers/phy/ti/phy-tusb1210.c:158:12: sparse: sparse:
> symbol 'tusb1210_chg_det_states' was not declared. Should it be static?
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-11 14:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-11 13:54 [PATCH] phy: ti: tusb1210: Make tusb1210_chg_det_states static Hans de Goede
2022-04-11 14:40 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).