From: Greg KH <gregkh@linuxfoundation.org>
To: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Cc: balbi@kernel.org, michal.simek@xilinx.com,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: udc-xilinx: remove unnecessary initialization of list iterator
Date: Fri, 22 Apr 2022 14:59:29 +0200 [thread overview]
Message-ID: <YmKmscbVVZazEkoh@kroah.com> (raw)
In-Reply-To: <20220316075153.3708-1-xiam0nd.tong@gmail.com>
On Wed, Mar 16, 2022 at 03:51:53PM +0800, Xiaomeng Tong wrote:
> 'req' will always be set by the subsequent list_for_each_entry()
> before any uses. Thus, to avoid ambiguity it is better to remove
> the unnecessary initialization of list iterator 'req'.
>
> Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
> ---
> drivers/usb/gadget/udc/udc-xilinx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c
> index 6ce886fb7..fa6cbfc63 100644
> --- a/drivers/usb/gadget/udc/udc-xilinx.c
> +++ b/drivers/usb/gadget/udc/udc-xilinx.c
> @@ -1136,7 +1136,7 @@ static int xudc_ep_queue(struct usb_ep *_ep, struct usb_request *_req,
> static int xudc_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req)
> {
> struct xusb_ep *ep = to_xusb_ep(_ep);
> - struct xusb_req *req = to_xusb_req(_req);
> + struct xusb_req *req;
> struct xusb_udc *udc = ep->udc;
> unsigned long flags;
>
> --
> 2.17.1
>
Does not apply anymore :(
prev parent reply other threads:[~2022-04-22 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 7:51 [PATCH] usb: gadget: udc-xilinx: remove unnecessary initialization of list iterator Xiaomeng Tong
2022-04-22 12:59 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmKmscbVVZazEkoh@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=xiam0nd.tong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).