From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v1 0/2] acpi: Remove acpi_release_memory()
Date: Tue, 26 Apr 2022 13:43:24 +0200 [thread overview]
Message-ID: <Ymfa3F83zxgqD2pk@kroah.com> (raw)
In-Reply-To: <20220425114544.37595-1-heikki.krogerus@linux.intel.com>
On Mon, Apr 25, 2022 at 02:45:42PM +0300, Heikki Krogerus wrote:
> Hi,
>
> It seems there never were and there never will be actual devices that
> expose the UCSI ACPI mailbox interface. There are now PD controllers
> that support the UCSI interface, but they do not use the ACPI mailbox.
>
> So there is no point in mapping the mailbox with ioremap(), we can
> just use memremap(). That should make it possible to also remove the
> function acpi_release_memory(). That function was only there to make
> it possible to use ioremap() in the UCSI ACPI driver.
>
> thanks,
>
> Heikki Krogerus (2):
> usb: typec: ucsi: acpi: Map the mailbox with memremap()
> acpi: Remove the helper for deactivating memory region
>
> drivers/acpi/osl.c | 86 ------------------------------
> drivers/usb/typec/ucsi/ucsi_acpi.c | 19 ++-----
> include/linux/acpi.h | 3 --
> 3 files changed, 4 insertions(+), 104 deletions(-)
>
> --
> 2.35.1
>
Look good to me, Rafael, want me to take this through the USB tree? Or
if you want to take it through the USB tree, here's my reviewed-by:
either is fine with me.
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2022-04-26 11:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 11:45 [PATCH v1 0/2] acpi: Remove acpi_release_memory() Heikki Krogerus
2022-04-25 11:45 ` [PATCH v1 1/2] usb: typec: ucsi: acpi: Map the mailbox with memremap() Heikki Krogerus
2022-04-25 11:45 ` [PATCH v1 2/2] acpi: Remove the helper for deactivating memory region Heikki Krogerus
2022-04-26 11:43 ` Greg Kroah-Hartman [this message]
2022-04-27 18:46 ` [PATCH v1 0/2] acpi: Remove acpi_release_memory() Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ymfa3F83zxgqD2pk@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox