public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
Cc: linux-usb@vger.kernel.org, marcel@holtmann.org
Subject: Re: [PATCH] Bluetooth: btusb: CSR chip hangs when unbound
Date: Fri, 29 Apr 2022 17:46:27 +0200	[thread overview]
Message-ID: <YmwIUztEs9OlZQB8@kroah.com> (raw)
In-Reply-To: <20220429153138.935435-1-jtornosm@redhat.com>

On Fri, Apr 29, 2022 at 05:31:38PM +0200, Jose Ignacio Tornos Martinez wrote:
> Bluetooth Dongles with CSR chip (i.e. USB Bluetooth V4.0 Dongle by
> Trust) hang when they are unbound from 'unbind' sysfs entry and
> can not be bound again.
> 
> The reason is CSR chip hangs when usb configuration command with
> index 0 (used to unconfigure) is sent during disconnection.
> 
> To avoid this unwanted result, it is necessary not to send this
> command for CSR chip when usb device is unbound.
> Besides, "skip_unconfigure" sysfs entry has been created for
> testing purposes with these or other devices.
> 
> Athough device is not unconfigured, it is better to avoid device
> hanging to be able to operate. Even bluetooth can be previously
> turned off.
> On the other hand, this is not important if usb device is going to
> be bound again (normal behavior), i.e. with usbip.
> 
> Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
> ---
>  drivers/bluetooth/btusb.c  |  8 +++++++-
>  drivers/usb/core/generic.c |  2 +-
>  drivers/usb/core/sysfs.c   | 36 ++++++++++++++++++++++++++++++++++++
>  include/linux/usb.h        |  2 ++
>  4 files changed, 46 insertions(+), 2 deletions(-)

No documentation for this new sysfs attribute you wish to create?
That's not going to help us with review :(

thanks,

greg k-h

  reply	other threads:[~2022-04-29 15:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29 15:31 [PATCH] Bluetooth: btusb: CSR chip hangs when unbound Jose Ignacio Tornos Martinez
2022-04-29 15:46 ` Greg KH [this message]
2022-04-30  1:11 ` Alan Stern
2022-04-30  7:31   ` Jose Ignacio Tornos Martinez
  -- strict thread matches above, loose matches on Subject: below --
2022-05-02  7:07 Jose Ignacio Tornos Martinez
2022-05-02 12:04 ` Greg KH
2022-05-02 12:04 ` Greg KH
2022-05-02 12:04 ` Greg KH
2022-05-02 14:22 ` Alan Stern
2022-05-03  6:13   ` Jose Ignacio Tornos Martinez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmwIUztEs9OlZQB8@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jtornosm@redhat.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox