Re: [PATCH v3 6/6] thunderbolt: Change TMU mode to HiFi uni-directional once DisplayPort tunneled

Mika Westerberg
2022-05-16T08:34:33Z

Hi Gil,

On Sun, May 15, 2022 at 11:27:46PM +0300, Gil Fine wrote:
> > > +int tb_switch_tmu_config_enable(struct device *dev, void *data)
> >
> > Also can we please make it take some real type and not something
> > arbitrary?
> You mean the names, right?
> Something like:
> int tb_switch_tmu_config_enable(struct device *parent, void *rate)
> If so, yes, I will

I mean use a real type, not void *.

> >
> > Can it be const too?
> IIUC, it shall be a function pointer with specified signature otherwise it will fail
> at compilation

Okay then I suggest to make a reasonable "API" function that handles
all this internally that does not take arbitrary pointers. Remember to
document it in kernel-doc too.