public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, Marcel Holtmann <marcel@holtmann.org>
Subject: Re: [PATCH v5] USB: core: skip unconfiguration if device doesn't support it
Date: Fri, 13 May 2022 10:09:26 -0400	[thread overview]
Message-ID: <Yn5mliJq+7W8khe9@rowland.harvard.edu> (raw)
In-Reply-To: <CABk-BGte9qHwmdqCU6oZ9-E3LvOqcMf3z46e00hypNdD_hPxPQ@mail.gmail.com>

On Fri, May 13, 2022 at 11:50:26AM +0200, Jose Ignacio Tornos Martinez wrote:
> Ok, I will try to identify the "bad" devices in some way.
> 
> Thanks
> 
> José Ignacio
> 
> 
> On Thu, May 12, 2022 at 1:48 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > I'll drop this for now as there are no in-kernel users for this quirk
> > yet.  When there is a need for one, please resubmit it.

Hold on; Greg's comment doesn't seem fair.  There are no in-kernel 
users for this quirk because it is meant to be a user API.  (Just as 
there are no in-kernel users for read(2) -- it is there so that 
userspace can call it).

Jose does have users for the new quirk: Anybody with one of the bad 
Bluetooth CSR knockoff chips.  Now I agree; it would be great if there 
was some way to identify them automatically.  But if that's not 
possible, the only alternative is to allow userspace to set the quirk 
flag whenever it knows the quirk is needed.

Alan Stern

  reply	other threads:[~2022-05-13 14:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-04 15:16 [PATCH v5] USB: core: skip unconfiguration if device doesn't support it Jose Ignacio Tornos Martinez
2022-05-04 17:54 ` Alan Stern
2022-05-12 11:47 ` Greg KH
2022-05-13  9:50   ` Jose Ignacio Tornos Martinez
2022-05-13 14:09     ` Alan Stern [this message]
2022-05-13 14:13       ` Greg KH
2022-05-13 14:26         ` Alan Stern
2022-05-13 14:46           ` Greg KH
2022-05-13 14:58             ` Jose Ignacio Tornos Martinez
2022-05-17 13:58               ` Jose Ignacio Tornos Martinez
2022-05-13 15:00           ` Bjørn Mork
2022-05-16  5:45             ` Jose Ignacio Tornos Martinez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yn5mliJq+7W8khe9@rowland.harvard.edu \
    --to=stern@rowland.harvard.edu \
    --cc=gregkh@linuxfoundation.org \
    --cc=jtornosm@redhat.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox