From: Johan Hovold <johan@kernel.org>
To: Ethan Yang <etyang@sierrawireless.com>
Cc: "皓宇 �" <ipis.yang@gmail.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Glen Chiang" <GChiang@sierrawireless.com>
Subject: Re: [PATCH v3] usb: serial: qcserial: add support for Sierra Wireless EM7590
Date: Thu, 5 May 2022 15:51:00 +0200 [thread overview]
Message-ID: <YnPWRJT+NoxQcp7a@hovoldconsulting.com> (raw)
In-Reply-To: <BL0PR02MB4451F88B384BA9D7FCE6A7C3ABC29@BL0PR02MB4451.namprd02.prod.outlook.com>
On Thu, May 05, 2022 at 12:35:41PM +0000, Ethan Yang wrote:
> Hi Johan,
>
> Here is the change log:
> To revise the correct composition for QDL/APP mode.
> 1199:c080 is for QDL, and 1199:c081 is for APP mode.
I meant that when you when you resend a new version of a patch you
should include a changelog for what changed since the previous
version(s) (below the --- line).
In this case I think you only changed the From address from v1 to v2,
but I'm not sure.
No need to resend, but please keep that in mind for your future
submissions.
> I also enclose the lsusb -v output for both compositions.
Thanks a lot for that.
I've applied the patch now.
Johan
prev parent reply other threads:[~2022-05-05 13:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 3:42 [PATCH] add support for Sierra Wireless EM7590 0xc080 and 0xc081 compositions Ethan Yang
2022-04-25 3:55 ` [PATCH v2] " Ethan Yang
2022-04-25 5:18 ` Greg KH
2022-04-25 5:58 ` [PATCH v3] usb: serial: qcserial: add support for Sierra Wireless EM7590 ipis.yang
2022-05-05 11:29 ` Johan Hovold
2022-05-05 12:35 ` Ethan Yang
2022-05-05 13:51 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnPWRJT+NoxQcp7a@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=GChiang@sierrawireless.com \
--cc=etyang@sierrawireless.com \
--cc=gregkh@linuxfoundation.org \
--cc=ipis.yang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox