From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Linyu Yuan <quic_linyyuan@quicinc.com>
Cc: linux-usb@vger.kernel.org, Jack Pham <quic_jackp@quicinc.com>
Subject: Re: [PATCH v3 2/4] usb: gadget: f_sourcesink: use DECLARE_USB_FUNCTION_INIT()
Date: Mon, 9 May 2022 14:49:15 +0200 [thread overview]
Message-ID: <YnkNy1Wd2lt11kSP@kroah.com> (raw)
In-Reply-To: <1652097288-19909-3-git-send-email-quic_linyyuan@quicinc.com>
On Mon, May 09, 2022 at 07:54:46PM +0800, Linyu Yuan wrote:
> First there is no reason call lb_modinit() and lb_modexit()
> which belong to f_loopback.c,
> let's remove them here and remove two function prototype from g_zero.h.
Please properly format your paragraphs. Why the odd line-break?
> After first step, we can use DECLARE_USB_FUNCTION_INIT() macro
> to create module init/exit function implicit as it only
> register/unregister one usb function driver.
>
> Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
> ---
> v3: new add
What does "new add" mean?
Please be explicit and verbose.
confused,
greg k-h
next prev parent reply other threads:[~2022-05-09 12:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 11:54 [PATCH v3 0/4] usb: gadget: update DECLARE_USB_FUNCTION(_INIT) macro Linyu Yuan
2022-05-09 11:54 ` [PATCH v3 1/4] usb: gadget: f_mass_storage: fix warning of -Werror=unused-but-set-variable Linyu Yuan
2022-05-09 12:48 ` Greg Kroah-Hartman
2022-05-09 11:54 ` [PATCH v3 2/4] usb: gadget: f_sourcesink: use DECLARE_USB_FUNCTION_INIT() Linyu Yuan
2022-05-09 12:49 ` Greg Kroah-Hartman [this message]
2022-05-09 11:54 ` [PATCH v3 3/4] usb: gadget: f_loopback: use DECLARE_USB_FUNCTION_INIT() macro Linyu Yuan
2022-05-09 18:39 ` kernel test robot
2022-05-09 19:22 ` kernel test robot
2022-05-09 11:54 ` [PATCH v3 4/4] usb: gadget: add '_' in DECLARE_USB_FUNCTION(_INIT) macros Linyu Yuan
2022-05-09 12:50 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnkNy1Wd2lt11kSP@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_jackp@quicinc.com \
--cc=quic_linyyuan@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox