From: Greg KH <gregkh@linuxfoundation.org>
To: Hongyu Xie <xy521521@gmail.com>
Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, 125707942@qq.com,
wangqi@kylinos.cn, xiongxin@kylinos.cn,
Hongyu Xie <xiehongyu1@kylinos.cn>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v4 -next] usb: xhci: disable irq during initialization
Date: Thu, 16 Jun 2022 10:12:14 +0200 [thread overview]
Message-ID: <Yqrl3jGyUx7sZVdL@kroah.com> (raw)
In-Reply-To: <20220616080933.1238309-1-xiehongyu1@kylinos.cn>
On Thu, Jun 16, 2022 at 04:09:33PM +0800, Hongyu Xie wrote:
> irq is disabled in xhci_quiesce(called by xhci_halt, with bit:2 cleared
> in USBCMD register), but xhci_run(called by usb_add_hcd) re-enable it.
> It's possible that you will receive thousands of interrupt requests
> after initialization for 2.0 roothub. And you will get a lot of
> warning like, "xHCI dying, ignoring interrupt. Shouldn't IRQs be
> disabled?". This amount of interrupt requests will cause the entire
> system to freeze.
> This problem was first found on a device with ASM2142 host controller
> on it.
>
> Signed-off-by: Hongyu Xie <xiehongyu1@kylinos.cn>
> Reported-by: kernel test robot <lkp@intel.com>
the test robot did not find this original problem, it only found
problems with your original submission, which is different.
next prev parent reply other threads:[~2022-06-16 8:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 8:09 [PATCH v4 -next] usb: xhci: disable irq during initialization Hongyu Xie
2022-06-16 8:12 ` Greg KH [this message]
2022-06-16 8:24 ` 谢泓宇
2022-06-16 8:34 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yqrl3jGyUx7sZVdL@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=125707942@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mathias.nyman@intel.com \
--cc=wangqi@kylinos.cn \
--cc=xiehongyu1@kylinos.cn \
--cc=xiongxin@kylinos.cn \
--cc=xy521521@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox