From: Greg KH <gregkh@linuxfoundation.org>
To: Hyunwoo Kim <imv4bel@gmail.com>
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: host: ehci-q: Fix ehci_submit_single_step_set_feature annotation typo
Date: Tue, 21 Jun 2022 08:35:15 +0200 [thread overview]
Message-ID: <YrFmoyW3q2CPLpok@kroah.com> (raw)
In-Reply-To: <20220621062925.GA698414@ubuntu>
On Mon, Jun 20, 2022 at 11:29:25PM -0700, Hyunwoo Kim wrote:
> >From 3ba1bf7eb8e672fcd5be65080a265d3428d1303a Mon Sep 17 00:00:00 2001
> From: Hyunwoo Kim <imv4bel@gmail.com>
> Date: Mon, 20 Jun 2022 14:30:10 -0700
> Subject: [PATCH] usb: host: ehci-q: Fix ehci_submit_single_step_set_feature annotation typo
This shouldn't be in the body of the email, try using 'git send-email'
instead.
>
> I found the "argument" typo.
> It seems that "argument" is more correct than "arguement".
That is much better, thanks.
>
> Signed-off-by: Hyunwoo Kim <imv4bel@gmail.com>
> ---
> drivers/usb/host/ehci-q.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-q.c b/drivers/usb/host/ehci-q.c
> index 1163af6fad77..807e64991e3e 100644
> --- a/drivers/usb/host/ehci-q.c
> +++ b/drivers/usb/host/ehci-q.c
> @@ -1162,7 +1162,7 @@ submit_async (
> * This is done in two parts: first SETUP req for GetDesc is sent then
> * 15 seconds later, the IN stage for GetDesc starts to req data from dev
> *
> - * is_setup : i/p arguement decides which of the two stage needs to be
> + * is_setup : i/p argument decides which of the two stage needs to be
> * performed; TRUE - SETUP and FALSE - IN+STATUS
> * Returns 0 if success
> */
> --
> 2.25.1
>
> Dear Greg,
>
> I'm sending the patch back because the greg email bot emailed me.
> I don't think there was anything wrong with the patch format.
> Did I receive an email saying my patch was in the wrong format because
> my patch was a minor typo fix and the description was too short?
This looks better, but can you resend this without the above header in
the body and then we can apply it.
thanks,
greg k-h
next prev parent reply other threads:[~2022-06-21 6:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 21:36 [PATCH] usb: host: ehci-q: Fix ehci_submit_single_step_set_feature annotation typo Hyunwoo Kim
2022-06-21 6:05 ` Greg KH
2022-06-21 6:29 ` Hyunwoo Kim
2022-06-21 6:35 ` Greg KH [this message]
2022-06-21 6:42 ` Hyunwoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrFmoyW3q2CPLpok@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=imv4bel@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox