From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFF0BC43334 for ; Sun, 24 Jul 2022 14:16:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229745AbiGXOQF (ORCPT ); Sun, 24 Jul 2022 10:16:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbiGXOQD (ORCPT ); Sun, 24 Jul 2022 10:16:03 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E199627D; Sun, 24 Jul 2022 07:16:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id A0972CE0B1E; Sun, 24 Jul 2022 14:15:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A080FC3411E; Sun, 24 Jul 2022 14:15:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1658672158; bh=Z81hIs8cdbSbSj3eyFpQt8NRpRerp6ca5j7+Cp23M4A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e0TYVlUme59HZ9ym8UHlNLkJp/uEm3smK7iExjAAJ3H03BW8JkkUFE4+0KzXLhQUz TiJpzlry4KbaBIQUwVIm6KzyRzPFjiSK+ZOSUF0LK+uVFv3Yb715zt+ZkKYv70gQuJ zxC5hyxtK8n86sZ9in6lWL/NNZdPyYDU8b+i6SjQ= Date: Sun, 24 Jul 2022 16:15:55 +0200 From: Greg Kroah-Hartman To: Johan Hovold Cc: Yan Xinyu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] USB: serial: usb_wwan: replace DTR/RTS magic numbers with macros Message-ID: References: <20220722085040.704885-1-sdlyyxy@bupt.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Sun, Jul 24, 2022 at 04:07:17PM +0200, Johan Hovold wrote: > On Sun, Jul 24, 2022 at 03:50:52PM +0200, Greg Kroah-Hartman wrote: > > On Sun, Jul 24, 2022 at 11:10:22AM +0200, Johan Hovold wrote: > > > On Fri, Jul 22, 2022 at 04:50:40PM +0800, Yan Xinyu wrote: > > > > The usb_wwan_send_setup function generates DTR/RTS signals in compliance > > > > with CDC ACM standard. This patch changes magic numbers in this function > > > > to equivalent macros. > > > > > > > > Signed-off-by: Yan Xinyu > > > > --- > > > > v1->v2: > > > > * Fix Signed-off-by name. > > > > v2->v3: > > > > * Use already defined ACM_CTRL_DTR and ACM_CTRL_RTS in drivers/usb/class/cdc-acm.h > > > > --- > > > > drivers/usb/serial/usb_wwan.c | 11 +++++++---- > > > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/drivers/usb/serial/usb_wwan.c b/drivers/usb/serial/usb_wwan.c > > > > index dab38b63eaf7..5c8303bd3676 100644 > > > > --- a/drivers/usb/serial/usb_wwan.c > > > > +++ b/drivers/usb/serial/usb_wwan.c > > > > @@ -29,8 +29,10 @@ > > > > #include > > > > #include > > > > #include > > > > +#include > > > > #include > > > > #include > > > > +#include "../class/cdc-acm.h" > > > > > > If we are to use common defines, these would need to be added to > > > linux/usb/cdc.h first (parts of which are exposed to user space). > > > > > > Note that we already have at least three copies of these defines in the > > > tree. > > > > > > I'm fine with adding another copy for now and not have to deal with with > > > naming and cross driver updates. What do you think, Greg? > > > > I think Yan should write a patch series to unify these and make it > > right, instead of just papering over it all. > > Ok, I just fear it will be more work for us since that involves > decisions like whether it should be added to the uapi header, and then > we get into naming, etc. But we're in no rush. > > > Also this "../" stuff in a > > #include directive is not ok, I wouldn't recommend this change be taken > > as-is. > > That was never an option, but I'd be ok with taking the v2 which added > defines for the constants directly in the driver. These are global defines, in a public spec, and they should all just be in one place in the kernel. What's wrong with include/uapi/linux/cdc.h which is where the other ACM defined values are at? thanks, greg k-h