From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Sanjay R Mehta <sanmehta@amd.com>
Cc: andreas.noever@gmail.com, michael.jamet@intel.com,
YehezkelShB@gmail.com, Basavaraj.Natikar@amd.com,
mario.limonciello@amd.com, linux-usb@vger.kernel.org
Subject: Re: [PATCH v3] thunderbolt: Add DP out resource when DP tunnel is discovered.
Date: Thu, 4 Aug 2022 10:08:08 +0300 [thread overview]
Message-ID: <YutwWI8xENDkAtg9@lahna> (raw)
In-Reply-To: <a5b6e0a1-a334-1bc5-46fa-b9ee5f53688f@amd.com>
On Thu, Aug 04, 2022 at 12:34:09PM +0530, Sanjay R Mehta wrote:
> >> tunnel = tb_tunnel_discover_dp(tb, port, alloc_hopids);
> >
> > Here tunnel can be NULL...
> >
> >> + tb_dp_resource_available_discovered(tb, tunnel->dst_port);
> >
> > ... so this will crash and burn.
>
> Thanks. Agree, I will add check here and resend the patch.
Please don't add the check here but move this to tb_start() as I
suggested.
next prev parent reply other threads:[~2022-08-04 7:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 4:29 [PATCH v3] thunderbolt: Add DP out resource when DP tunnel is discovered Sanjay R Mehta
2022-08-04 6:30 ` Mika Westerberg
2022-08-04 7:04 ` Sanjay R Mehta
2022-08-04 7:08 ` Mika Westerberg [this message]
2022-08-04 8:09 ` Sanjay R Mehta
2022-08-04 8:31 ` Mika Westerberg
2022-08-04 8:57 ` Sanjay R Mehta
2022-08-04 9:15 ` Mika Westerberg
2022-08-04 9:25 ` Sanjay R Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YutwWI8xENDkAtg9@lahna \
--to=mika.westerberg@linux.intel.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=michael.jamet@intel.com \
--cc=sanmehta@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox