From: Greg KH <gregkh@linuxfoundation.org>
To: Ray Hung <tw.rayhung@gmail.com>
Cc: balbi@kernel.org, akpm@linux-foundation.org,
dh10.jung@samsung.com, songmuchun@bytedance.com,
dan.carpenter@oracle.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: rndis: use %u instead of %d to print u32 values
Date: Thu, 4 Aug 2022 13:25:40 +0200 [thread overview]
Message-ID: <YuustIMaImn+0UYc@kroah.com> (raw)
In-Reply-To: <20220804110836.138614-1-tw.rayhung@gmail.com>
On Thu, Aug 04, 2022 at 07:08:36PM +0800, Ray Hung wrote:
> The driver uses the %d format to print u32 values. The correct
> format is %u. Fix it.
>
> Signed-off-by: Ray Hung <tw.rayhung@gmail.com>
> ---
> drivers/usb/gadget/function/rndis.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/rndis.c b/drivers/usb/gadget/function/rndis.c
> index 713efd9aefde..10ba339bcea4 100644
> --- a/drivers/usb/gadget/function/rndis.c
> +++ b/drivers/usb/gadget/function/rndis.c
> @@ -1105,7 +1105,7 @@ static int rndis_proc_show(struct seq_file *m, void *v)
> "used : %s\n"
> "state : %s\n"
> "medium : 0x%08X\n"
> - "speed : %d\n"
> + "speed : %u\n"
> "cable : %s\n"
> "vendor ID : 0x%08X\n"
> "vendor : %s\n",
> --
> 2.25.1
>
What commit id does this fix?
And given this is only for debugging, there's no rush, right?
thanks,
greg k-h
next prev parent reply other threads:[~2022-08-04 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 11:08 [PATCH] usb: gadget: rndis: use %u instead of %d to print u32 values Ray Hung
2022-08-04 11:25 ` Greg KH [this message]
2022-08-04 12:07 ` Ray Hung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuustIMaImn+0UYc@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=balbi@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=dh10.jung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=songmuchun@bytedance.com \
--cc=tw.rayhung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox