Linux USB
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dongliang Mu <dzm91@hust.edu.cn>
Cc: Dongliang Mu <mudongliangabcd@gmail.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] USB: trancevibrator: simplify tv_probe
Date: Thu, 18 Aug 2022 17:06:56 +0200	[thread overview]
Message-ID: <Yv5VkNvk6CDBFgNK@kroah.com> (raw)
In-Reply-To: <20220812061805.88627-2-dzm91@hust.edu.cn>

On Fri, Aug 12, 2022 at 02:18:02PM +0800, Dongliang Mu wrote:
> From: Dongliang Mu <mudongliangabcd@gmail.com>
> 
> The function tv_probe does not need to invoke kfree when the
> allocation fails. So let's simplify the code of tv_probe.
> 
> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> ---
> v2->v3: fix the truncated subject of PATCH 2/2.
> v1->v2: no change
> 
>  drivers/usb/misc/trancevibrator.c | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)

Note, I would recommend you work on basic "clean up" patches in the
drivers/staging/ directory so as to get experience on how to submit
patches properly before working in other parts of the kernel tree.  That
way subsystems that don't normally take "cleanup" patches don't get
bogged down in basic patch-process issues like this one did.

thanks,

greg k-h

  reply	other threads:[~2022-08-18 15:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12  6:18 [PATCH v3 1/2] USB: trancevibrator: remove redundant space Dongliang Mu
2022-08-12  6:18 ` [PATCH v3 2/2] USB: trancevibrator: simplify tv_probe Dongliang Mu
2022-08-18 15:06   ` Greg Kroah-Hartman [this message]
2022-08-18 15:15     ` Dongliang Mu
2022-08-12  6:26 ` [PATCH v3 1/2] USB: trancevibrator: remove redundant space Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yv5VkNvk6CDBFgNK@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dzm91@hust.edu.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mudongliangabcd@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox