linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] usb-storage: Add ignore-residue quirk for NXP PN7462AU
@ 2022-08-09 11:29 Witold Lipieta
  2022-08-09 19:28 ` Alan Stern
  0 siblings, 1 reply; 2+ messages in thread
From: Witold Lipieta @ 2022-08-09 11:29 UTC (permalink / raw)
  To: USB development list; +Cc: Witold Lipieta

This is USB mass storage primary boot loader for code download on
NXP PN7462AU.

Without the quirk it is impossible to write whole memory at once as
device restarts during the write due to bogus residue values reported.

Signed-off-by: Witold Lipieta <witold.lipieta@thaumatec.com>
---
Output from /sys/kernel/debug/usb/devices:
T:  Bus=02 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#=  4 Spd=12   MxCh= 0
D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
P:  Vendor=1fc9 ProdID=0117 Rev= 1.00
S:  Manufacturer=NXP
S:  Product=PN7462AU
C:* #Ifs= 1 Cfg#= 1 Atr=c0 MxPwr=100mA
I:* If#= 0 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-storage
E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=0ms
E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=0ms
 drivers/usb/storage/unusual_devs.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index b6a9a7451620..ee6923b6ab31 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -2265,6 +2265,13 @@ UNUSUAL_DEV( 0x1e74, 0x4621, 0x0000, 0x0000,
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		US_FL_BULK_IGNORE_TAG | US_FL_MAX_SECTORS_64 ),
 
+/* Reported by Witold Lipieta <witold.lipieta@thaumatec.com> */
+UNUSUAL_DEV( 0x1fc9, 0x0117, 0x0100, 0x0100,
+		"NXP Semiconductors",
+		"PN7462AU",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
+		US_FL_IGNORE_RESIDUE ),
+
 /* Supplied with some Castlewood ORB removable drives */
 UNUSUAL_DEV(  0x2027, 0xa001, 0x0000, 0x9999,
 		"Double-H Technology",
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] usb-storage: Add ignore-residue quirk for NXP PN7462AU
  2022-08-09 11:29 [PATCH] usb-storage: Add ignore-residue quirk for NXP PN7462AU Witold Lipieta
@ 2022-08-09 19:28 ` Alan Stern
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2022-08-09 19:28 UTC (permalink / raw)
  To: Witold Lipieta, Greg KH; +Cc: USB development list

On Tue, Aug 09, 2022 at 01:29:11PM +0200, Witold Lipieta wrote:
> This is USB mass storage primary boot loader for code download on
> NXP PN7462AU.
> 
> Without the quirk it is impossible to write whole memory at once as
> device restarts during the write due to bogus residue values reported.
> 
> Signed-off-by: Witold Lipieta <witold.lipieta@thaumatec.com>
> ---

Acked-by: Alan Stern <stern@rowland.harvard.edu>

> Output from /sys/kernel/debug/usb/devices:
> T:  Bus=02 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#=  4 Spd=12   MxCh= 0
> D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
> P:  Vendor=1fc9 ProdID=0117 Rev= 1.00
> S:  Manufacturer=NXP
> S:  Product=PN7462AU
> C:* #Ifs= 1 Cfg#= 1 Atr=c0 MxPwr=100mA
> I:* If#= 0 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-storage
> E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=0ms
> E:  Ad=01(O) Atr=02(Bulk) MxPS=  64 Ivl=0ms
>  drivers/usb/storage/unusual_devs.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index b6a9a7451620..ee6923b6ab31 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -2265,6 +2265,13 @@ UNUSUAL_DEV( 0x1e74, 0x4621, 0x0000, 0x0000,
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>  		US_FL_BULK_IGNORE_TAG | US_FL_MAX_SECTORS_64 ),
>  
> +/* Reported by Witold Lipieta <witold.lipieta@thaumatec.com> */
> +UNUSUAL_DEV( 0x1fc9, 0x0117, 0x0100, 0x0100,
> +		"NXP Semiconductors",
> +		"PN7462AU",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> +		US_FL_IGNORE_RESIDUE ),
> +
>  /* Supplied with some Castlewood ORB removable drives */
>  UNUSUAL_DEV(  0x2027, 0xa001, 0x0000, 0x9999,
>  		"Double-H Technology",
> -- 
> 2.34.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-08-09 19:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-09 11:29 [PATCH] usb-storage: Add ignore-residue quirk for NXP PN7462AU Witold Lipieta
2022-08-09 19:28 ` Alan Stern

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).