Linux USB
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Frank Mori Hess <fmh6jj@gmail.com>
Cc: Minas Harutyunyan <hminas@synopsys.com>, linux-usb@vger.kernel.org
Subject: Re: [BUG] usb: dwc2: split interrupt in transactions silently dropped due to driver latency
Date: Sun, 14 Aug 2022 14:58:29 +0200	[thread overview]
Message-ID: <YvjxdYDe/SMl1lO+@kroah.com> (raw)
In-Reply-To: <CAJz5Opfcy-P+HbRQ2LK_-9C8Oz5q=26qZ--ZfYV74YtzhFH1Bw@mail.gmail.com>

On Sun, Aug 14, 2022 at 05:33:09AM -0700, Frank Mori Hess wrote:
> On Sat, Aug 13, 2022 at 8:08 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> > Then please work with your vendor as only they can provide the needed
> > support that you are already paying for.  Take advantage of that,
> > nothing we can do about odd vendor kernels, sorry.
> 
> I'm not looking for support, I've already fixed the bug for myself.
> I'm just trying to provide some useful information to the dwc2
> maintainer in case they care about fixing the bug.  The bug is
> obviously still present in the current mainline kernel.  From the
> dwc2_hc_nyet_intr function, they #ifdef out incrementing the
> error_count (as I tried to explain earlier, even incrementing the
> error_count is not enough, there needs to be a hard error):
> 
> #if 0
> /*
> * Todo: Fix system performance so this can
> * be treated as an error. Right now complete
> * splits cannot be scheduled precisely enough
> * due to other system activity, so this error
> * occurs regularly in Slave mode.
> */
> qtd->error_count++;
> #endif

If you have a fix, please, send it as a normal patch submission so we
can review and accept it like normal.  No need to do anything else here
out-of-the-ordinary.

thanks,

greg k-h

      reply	other threads:[~2022-08-14 12:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-13  1:37 [BUG] usb: dwc2: split interrupt in transactions silently dropped due to driver latency Frank Mori Hess
2022-08-13  7:15 ` Greg KH
2022-08-13 14:52   ` Frank Mori Hess
2022-08-13 15:08     ` Greg KH
2022-08-14 12:33       ` Frank Mori Hess
2022-08-14 12:58         ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YvjxdYDe/SMl1lO+@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=fmh6jj@gmail.com \
    --cc=hminas@synopsys.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox