From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Badhri Jagan Sridharan <badhri@google.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Kyle Tso <kyletso@google.com>
Subject: Re: [PATCH v1 3/4] usb: typec: tcpci_maxim: Export helper function for register reads
Date: Tue, 30 Aug 2022 15:00:39 +0200 [thread overview]
Message-ID: <Yw4J9wv1N2Z5/qbN@kroah.com> (raw)
In-Reply-To: <20220826084001.3341215-3-badhri@google.com>
On Fri, Aug 26, 2022 at 01:40:00AM -0700, Badhri Jagan Sridharan wrote:
> Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
As Heikki pointed out, I can not accept changes with no changelog text
at all, you know this.
Please write a good changelog text that explains why you are doing this
so we can properly review it. As it is, we have no idea what is going
on here at all.
thanks,
greg k-h
next prev parent reply other threads:[~2022-08-30 13:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 8:39 [PATCH v1 1/4] usb: typec: tcpm: Add callbacks to mitigate wakeups due to contaminant Badhri Jagan Sridharan
2022-08-26 8:39 ` [PATCH v1 2/4] usb: typec: tcpci: Add callback for evaluating contaminant presence Badhri Jagan Sridharan
2022-08-26 8:40 ` [PATCH v1 3/4] usb: typec: tcpci_maxim: Export helper function for register reads Badhri Jagan Sridharan
2022-08-30 10:57 ` Heikki Krogerus
2022-08-30 13:00 ` Greg Kroah-Hartman [this message]
2022-08-31 0:20 ` Badhri Jagan Sridharan
2022-08-26 8:40 ` [PATCH v1 4/4] usb: typec: maxim_contaminant: Implement check_contaminant callback Badhri Jagan Sridharan
2022-08-30 17:55 ` Guenter Roeck
2022-08-31 0:22 ` Badhri Jagan Sridharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw4J9wv1N2Z5/qbN@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=badhri@google.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox