From: Greg KH <greg@kroah.com>
To: cgel.zte@gmail.com
Cc: stern@rowland.harvard.edu, skhan@linuxfoundation.org,
richard.leitner@skidata.com, tasos@tasossah.com,
wsa+renesas@sang-engineering.com, ingo.rohloff@lauterbach.com,
cui.jinpeng2@zte.com.cn, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] usb: core: remove redundant variables ret
Date: Tue, 30 Aug 2022 17:24:49 +0200 [thread overview]
Message-ID: <Yw4rweh3lKeWkZJ5@kroah.com> (raw)
In-Reply-To: <20220830143318.299640-1-cui.jinpeng2@zte.com.cn>
On Tue, Aug 30, 2022 at 02:33:18PM +0000, cgel.zte@gmail.com wrote:
> From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
>
> Rturn value directly from usbdev_do_ioctl() instead of
> getting value from redundant variable ret.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
As stated before, please read the documentation for how to handle stuff
coming from research tools like this and properly document it in your
changelog text.
Also, why is this being sent from a gmail account? How do we know this
is really from a zte.com.cn address?
thanks,
greg k-h
prev parent reply other threads:[~2022-08-30 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 14:33 [PATCH linux-next] usb: core: remove redundant variables ret cgel.zte
2022-08-30 15:24 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw4rweh3lKeWkZJ5@kroah.com \
--to=greg@kroah.com \
--cc=cgel.zte@gmail.com \
--cc=cui.jinpeng2@zte.com.cn \
--cc=ingo.rohloff@lauterbach.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=richard.leitner@skidata.com \
--cc=skhan@linuxfoundation.org \
--cc=stern@rowland.harvard.edu \
--cc=tasos@tasossah.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox