From: Alan Stern <stern@rowland.harvard.edu>
To: Hu Xiaoying <huxiaoying2008@gmail.com>
Cc: usb-storage@lists.one-eyed-alien.net, linux-usb@vger.kernel.org,
gregkh@linuxfoundation.org
Subject: Re: [PATCH v2] usb: Improves USB2.0 write performance
Date: Mon, 29 Aug 2022 09:56:52 -0400 [thread overview]
Message-ID: <YwzFpJeoIPjOS8K7@rowland.harvard.edu> (raw)
In-Reply-To: <CABd4UjYS4QDozv-RKp3_9XhQec=LO+z9U8+=Oa8=MEFyaeXYhA@mail.gmail.com>
On Mon, Aug 29, 2022 at 04:58:57PM +0800, Hu Xiaoying wrote:
> From: Hu Xiaoying <huxiaoying@gmail.com>
>
> USB external storage device(0x0b05:1932), use gnome-disk-utility tools
> to test usb write < 30MB/s.
> Then, igoned to load module of uas for this device.
--------^^^^^^
"igoned" is not a word in English.
> ===============================================
Why did you put this line here?
> Write speed: Improves form 27MB/s to 40MB/s+
------------------------^^^^
---------------------------------------^^^^^^^
"from", not "form".
"> 40MB/s", not "40MB/s+".
>
> Signed-off-by: Hu Xiaoying <huxiaoying@gmail.com>
> ---
> drivers/usb/storage/unusual_uas.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/usb/storage/unusual_uas.h
> b/drivers/usb/storage/unusual_uas.h
> index 4051c8cd0cd8..abaf4ea8138b 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -157,3 +157,10 @@ UNUSUAL_DEV(0x4971, 0x8024, 0x0000, 0x9999,
> "External HDD",
> USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> US_FL_ALWAYS_SYNC),
> +
> +/* Reported-by: Tom Hu <huxiaoying@gmail.com> */
> +UNUSUAL_DEV(0x0b05, 0x1932, 0x0000, 0x9999,
> + "ASUS",
> + "External HDD",
> + USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> + US_FL_IGNORE_UAS),
Entries should be sorted by vendor ID and product ID. This entry is
added in the wrong place (0x0b05 comes before 0x4971, not after).
Alan Stern
next prev parent reply other threads:[~2022-08-29 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CABd4UjYS4QDozv-RKp3_9XhQec=LO+z9U8+=Oa8=MEFyaeXYhA@mail.gmail.com>
2022-08-29 9:04 ` [PATCH v2] usb: Improves USB2.0 write performance Greg KH
2022-08-29 13:56 ` Alan Stern [this message]
[not found] <CABd4UjYSaZv6H9Q-UbM8QQZk8HcBPrJ7=DfDQGxJNVNot68Kfg@mail.gmail.com>
2022-08-29 8:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwzFpJeoIPjOS8K7@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=huxiaoying2008@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox