From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CCC1C54EE9 for ; Fri, 9 Sep 2022 01:50:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229686AbiIIBuE (ORCPT ); Thu, 8 Sep 2022 21:50:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229623AbiIIBuC (ORCPT ); Thu, 8 Sep 2022 21:50:02 -0400 Received: from netrider.rowland.org (netrider.rowland.org [192.131.102.5]) by lindbergh.monkeyblade.net (Postfix) with SMTP id B483558B75 for ; Thu, 8 Sep 2022 18:49:53 -0700 (PDT) Received: (qmail 475028 invoked by uid 1000); 8 Sep 2022 21:49:52 -0400 Date: Thu, 8 Sep 2022 21:49:52 -0400 From: Alan Stern To: Hongling Zeng Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, zhongling0719@126.com Subject: Re: [PATCH v2 2/3] usb-storage: Add Hiksemi USB3-FW to IGNORE_UAS Message-ID: References: <1662604981055928.8.seg@mailgw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1662604981055928.8.seg@mailgw> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Sep 07, 2022 at 10:54:16AM +0800, Hongling Zeng wrote: > The UAS mode of Hiksemi USB_HDD is reported to fail to work on several > platforms with the following error message, then after re-connecting the > device will be offlined and not working at all. > > [ 592.518442][ 2] sd 8:0:0:0: [sda] tag#17 uas_eh_abort_handler 0 uas-tag 18 > inflight: CMD > [ 592.527575][ 2] sd 8:0:0:0: [sda] tag#17 CDB: Write(10) 2a 00 03 6f 88 00 00 > 04 00 00 > [ 592.536330][ 2] sd 8:0:0:0: [sda] tag#0 uas_eh_abort_handler 0 uas-tag 1 > inflight: CMD > [ 592.545266][ 2] sd 8:0:0:0: [sda] tag#0 CDB: Write(10) 2a 00 07 44 1a 88 00 > 00 08 00 > > These disks have a broken uas implementation, the tag field of the status > iu-s is not set properly,so we need to fall-back to usb-storage. > > Signed-off-by: Hongling Zeng > --- > Change for v1 > - Change the email real name and the code worng place. > > Change for v2 > -Change spelling error. > > --- > drivers/usb/storage/unusual_uas.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h > index a6bf87a..8a18d58 100644 > --- a/drivers/usb/storage/unusual_uas.h > +++ b/drivers/usb/storage/unusual_uas.h > @@ -149,6 +149,13 @@ UNUSUAL_DEV(0x0bc2, 0xab2a, 0x0000, 0x9999, > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > US_FL_NO_ATA_1X), > > +/* Reported-by: Hongling Zeng */ > +UNUSUAL_DEV(0x0bda, 0x9210, 0x0000, 0x9999, > + "Hiksemi", > + "External HDD", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > + US_FL_IGNORE_UAS), > + > /* Reported-by: Benjamin Tissoires */ > UNUSUAL_DEV(0x13fd, 0x3940, 0x0000, 0x9999, > "Initio Corporation", Acked-by: Alan Stern