From: Alan Stern <stern@rowland.harvard.edu>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: Replace NO_IRQ by 0
Date: Thu, 6 Oct 2022 09:50:27 -0400 [thread overview]
Message-ID: <Yz7dI5iTaguhn73K@rowland.harvard.edu> (raw)
In-Reply-To: <63f6d2e7ea17f6522f36abd6cf5e6a7f25f215c6.1665033267.git.christophe.leroy@csgroup.eu>
On Thu, Oct 06, 2022 at 07:15:44AM +0200, Christophe Leroy wrote:
> NO_IRQ is used to check the return of irq_of_parse_and_map().
>
> On some architecture NO_IRQ is 0, on other architectures it is -1.
>
> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
This isn't clear. Does absence of an irq count as an error? In other
words, will irq_of_parse_and_map() sometimes return 0 and other times
return NO_IRQ? What about architectures on which 0 is a valid irq
number?
> So use 0 instead of using NO_IRQ.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
> drivers/usb/host/ehci-grlib.c | 2 +-
> drivers/usb/host/ehci-ppc-of.c | 2 +-
> drivers/usb/host/fhci-hcd.c | 2 +-
> drivers/usb/host/ohci-ppc-of.c | 2 +-
> drivers/usb/host/uhci-grlib.c | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-grlib.c b/drivers/usb/host/ehci-grlib.c
> index a2c3b4ec8a8b..0717f2ccf49d 100644
> --- a/drivers/usb/host/ehci-grlib.c
> +++ b/drivers/usb/host/ehci-grlib.c
> @@ -99,7 +99,7 @@ static int ehci_hcd_grlib_probe(struct platform_device *op)
> hcd->rsrc_len = resource_size(&res);
>
> irq = irq_of_parse_and_map(dn, 0);
> - if (irq == NO_IRQ) {
> + if (!irq) {
> dev_err(&op->dev, "%s: irq_of_parse_and_map failed\n",
> __FILE__);
> rv = -EBUSY;
Since NO_IRQ is sometimes set to -1, shouldn't this test (and all the
other ones you changed) really be doing:
if (!irq || irq == NO_IRQ) { ...
?
Alan Stern
next prev parent reply other threads:[~2022-10-06 13:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 5:15 [PATCH] usb: Replace NO_IRQ by 0 Christophe Leroy
2022-10-06 13:50 ` Alan Stern [this message]
2022-10-06 14:01 ` Christophe Leroy
2022-10-06 14:24 ` Alan Stern
2022-11-10 17:57 ` Christophe Leroy
2022-10-06 14:05 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz7dI5iTaguhn73K@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=christophe.leroy@csgroup.eu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox