From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D820C04A95 for ; Wed, 28 Sep 2022 13:45:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234132AbiI1Npw (ORCPT ); Wed, 28 Sep 2022 09:45:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229698AbiI1Npt (ORCPT ); Wed, 28 Sep 2022 09:45:49 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 694B936843; Wed, 28 Sep 2022 06:45:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 34ED9B820D3; Wed, 28 Sep 2022 13:45:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70008C433D6; Wed, 28 Sep 2022 13:45:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664372742; bh=2kibBR7rJ5YXYGVM0U2w3frRacYCZDTp7HUULPPogRs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SnIyFxCuMJlsaOMMrEAecc6fAY50ozfpX6FhZwBAa5ckuGTOneJxwXvOVGVDnFym/ 2e7vCMcF4/vhKngkcRPZH3Y1mFcRml2QtzukEWmpZw7Xp3nRDCghMmOcqKN6/NEitC qCNIPKk9SD5ZcKByvGHS4ni/PKJH8+xrRCT22hLE= Date: Wed, 28 Sep 2022 15:45:40 +0200 From: Greg KH To: Wayne Chang Cc: heikki.krogerus@linux.intel.com, Sanket.Goswami@amd.com, singhanc@nvidia.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] usb: typec: ucsi_ccg: Disable UCSI ALT support on Tegra Message-ID: References: <20220928131615.3286936-1-waynec@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220928131615.3286936-1-waynec@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Sep 28, 2022 at 09:16:15PM +0800, Wayne Chang wrote: > From: Sing-Han Chen > > Firmware built for Tegra doesn't support UCSI ALT > command and has known issue of reporting wrong > capability info. > > This commit disables UCSI ALT support when reading > the capability on Tegra. You have a full 72 columns to use, no need to make it shorter :) > > Signed-off-by: Sing-Han Chen > Signed-off-by: Wayne Chang > --- > drivers/usb/typec/ucsi/ucsi_ccg.c | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c > index 5c0bf48be766..fde3da0605f5 100644 > --- a/drivers/usb/typec/ucsi/ucsi_ccg.c > +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c > @@ -122,9 +122,14 @@ struct version_format { > * Firmware version 3.1.10 or earlier, built for NVIDIA has known issue > * of missing interrupt when a device is connected for runtime resume > */ > -#define CCG_FW_BUILD_NVIDIA (('n' << 8) | 'v') > +#define CCG_FW_BUILD_NVIDIA_RTX (('n' << 8) | 'v') Why change this here? It's not needed, just add the new command instead. And what commit id does this fix? Is it needed for stable kernels? If so, how far back? thanks, greg k-h