From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87A08C433FE for ; Fri, 30 Sep 2022 11:51:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229571AbiI3Lvm (ORCPT ); Fri, 30 Sep 2022 07:51:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231389AbiI3LvX (ORCPT ); Fri, 30 Sep 2022 07:51:23 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86D32DF91; Fri, 30 Sep 2022 04:48:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 44D11B8279B; Fri, 30 Sep 2022 11:48:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6812FC433C1; Fri, 30 Sep 2022 11:48:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664538514; bh=/1kyDSTtDbTAy1WPXIL9kZ2yVlvUfIRMJtTLl5zFNU8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SVDfrr3lwGP+gRaGSkJOf5MXbT+/r2HCkN9pd2uz55RmE3rZJUpKsZlF2ksXdsCRh mC3EkiEI1ZL7ouk3g5j20Gil1dJAPR/DpZphJkkRrihMAX8ykmPYFtDKX8vp/rrIKZ zr1QlLmzoL15CG15iOBzdorbofBRgi61bWdW7vwU= Date: Fri, 30 Sep 2022 13:48:32 +0200 From: Greg Kroah-Hartman To: patrice.chotard@foss.st.com Cc: Felipe Balbi , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jerome Audu , Felipe Balbi Subject: Re: [PATCH v2] usb: dwc3: st: Rely on child's compatible instead of name Message-ID: References: <20220930072707.516270-1-patrice.chotard@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220930072707.516270-1-patrice.chotard@foss.st.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Sep 30, 2022 at 09:27:07AM +0200, patrice.chotard@foss.st.com wrote: > From: Patrice Chotard > > To ensure that child node is found, don't rely on child's node name > which can take different value, but on child's compatible name. > > Fixes: f5c5936d6b4d ("usb: dwc3: st: Fix node's child name") > > Cc: Jerome Audu > Reported-by: Felipe Balbi > Signed-off-by: Patrice Chotard > --- > drivers/usb/dwc3/dwc3-st.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c > index 166b5bde45cb..fea5290de83f 100644 > --- a/drivers/usb/dwc3/dwc3-st.c > +++ b/drivers/usb/dwc3/dwc3-st.c > @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev) > /* Manage SoftReset */ > reset_control_deassert(dwc3_data->rstc_rst); > > - child = of_get_child_by_name(node, "dwc3"); > + child = of_get_compatible_child(node, "snps,dwc3"); > if (!child) { > dev_err(&pdev->dev, "failed to find dwc3 core node\n"); > ret = -ENODEV; > -- > 2.25.1 > This commit doesn't even apply to my tree. What branch is it against? confused, greg k-h