From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: syzbot <syzbot+c38e5e60d0041a99dbf5@syzkaller.appspotmail.com>,
gregkh@linuxfoundation.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] media: dvb: usb: Fix WARNING in dib0700_i2c_xfer/usb_submit_urb
Date: Tue, 25 Mar 2025 23:17:32 +0100 [thread overview]
Message-ID: <Z-MrfICsY06DZV-2@shikoro> (raw)
In-Reply-To: <d0fd60d7-5660-42ed-b1c7-4dfd6b8e74b0@rowland.harvard.edu>
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
On Tue, Mar 25, 2025 at 05:47:53PM -0400, Alan Stern wrote:
> On Tue, Mar 25, 2025 at 08:56:57PM +0100, Wolfram Sang wrote:
> >
> > > + static const struct i2c_adapter_quirks i2c_usb_quirks = {
> > > + .flags = I2C_AQ_NO_ZERO_LEN_READ,
> > > + };
> >
> > Why didn't you create the static struct outside of probe?
>
> Because it's used only in that one function. But if you prefer, I will
> move the definition outside of the function. It doesn't make any real
> difference.
Then, for consistency reasons, I'd really prefer it outside probe. I
also think it doesn't really make a difference, it just looks unusual to
me.
Thanks and happy hacking!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-03-25 22:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 18:18 [syzbot] [usb?] WARNING in dib0700_i2c_xfer/usb_submit_urb syzbot
2025-03-24 19:08 ` Alan Stern
2025-03-24 19:19 ` Wolfram Sang
2025-03-25 16:41 ` Alan Stern
2025-03-25 16:59 ` Wolfram Sang
2025-03-25 17:47 ` Alan Stern
2025-03-25 19:07 ` syzbot
2025-03-25 19:28 ` [PATCH] media: dvb: usb: Fix " Alan Stern
2025-03-25 19:56 ` Wolfram Sang
2025-03-25 21:47 ` Alan Stern
2025-03-25 22:17 ` Wolfram Sang [this message]
2025-03-26 15:28 ` [PATCH v2] " Alan Stern
2025-03-26 15:54 ` Wolfram Sang
2025-03-26 16:04 ` Alan Stern
2025-03-26 21:32 ` Wolfram Sang
2025-03-27 16:10 ` [PATCH v2 resend] " Alan Stern
2025-03-28 15:45 ` Wolfram Sang
2025-03-29 2:08 ` Alan Stern
2025-03-29 6:05 ` Wolfram Sang
2025-03-29 14:31 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-MrfICsY06DZV-2@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=syzbot+c38e5e60d0041a99dbf5@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox