Re: USB: serial: qcserial: patch for adding Sierra Wireless 9x50, EM91, EM92 and SDX35.

[Johan Hovold <johan@kernel.org>]

On Wed, Mar 26, 2025 at 08:36:23AM +0700, Lars Melin wrote:
> On 2025-03-21 05:08, Adam Xue wrote:

> > This is the patch for adding support for Sierra Wireless and Semtech products based on
> > Qualcomm 9x50, SDX35, SDX55 and SDX65 based products (EM75xx, EM91xx, EM92xx).
> > Currently, only our products based on Qualcomm 9x30 and older chipsets are supported.
> > These products have a different USB interface layout compared to the default one which
> > require code changes. The VID/PID list has also been updated for all products mentioned above.
> > Please review.

> this is a NAK of the patch from me. EM9191 (1199:90d3) is already 
> supported in the option serial driver and that is also where the other 
> Qualcomm SDX based Sierra devices should be included in my opinion.
> SDX devices from other mfgr are also supported in option so it makes no 
> sense to add more special code for Sierra in qcserial each time Sierra 
> decides to change their compositions for new devices.
> This is all up to Johan of course who may have a different opinion than me.

I fully agree. Thanks for reviewing, Lars.

Johan