From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CB151FBCA3 for ; Tue, 3 Dec 2024 15:11:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733238691; cv=none; b=ti5LZJCe5qAJiJNpHFGTXVDtPaO3+8KfCn61bNDAz7/Dcit1cshogShf5p7IxgZ+xh/J8yEqwcG/6N1lZMoCvhSiBNsWf0gtvSaYsjYlElN/VEcnwUB5yK5naWJfUIgtHf8RTUn4PHwz5zVRxN+PF9Ymw50F4p2V0bk7gWKJ+o4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733238691; c=relaxed/simple; bh=Uei6j24yL3vgxy4vncTGsY2siuJb0kM1VOXijaR88jw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D+aXlBLzlhG1CeUArKYGGPEmlVzOYLd7yhWDQLWZn0bxDUpkRwHA2aRM0UXM+eYoKE7f5FjRe3L7Z0Mok7wOPEO1CVlBk9RW3Hjvze/m/BY4OoUCuLM6Z/0JR6bd1uOaYyBTPFr2ed1rHHbMxgsrcWX5lx6Po7lzOzWEXf6KqYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=TTNZgXCU; arc=none smtp.client-ip=209.85.128.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TTNZgXCU" Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-434a1fe2b43so50911955e9.2 for ; Tue, 03 Dec 2024 07:11:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733238687; x=1733843487; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zREpKid1FijkM8w3fvUJYYcepCZqPc1/enXnI+QFhQI=; b=TTNZgXCU8vVl158hgBSDkr+Zx0cG0tZLufC86xognLJ6Os3DvGbcuG4ssB2k14dKOv l4yUZDM6ysHGjQNU5QPfapoDS07SEnjfz364PZyazpVkxUtfJLJh1heBO9UcmWMUVNdf dBKB92KSnfVJiWQXDgOTSEc7VFmrF2KiJ21wh7yQTAhr+ReXLBTksV2Jl9l1JJSC20+h 4ZBxnZIA1LSaKiK/nTEF/sCjoLEMpgzNfbKiDr61GPfiWssx8EW/zy4aSy3Q+kN8P7aA rr2FmXe1Wl0YLiI6D1smAnXDypdol8MCbuS9ZaUzsvxt0FlG+8AkYDHJcTasoCVZeOAW nusQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733238687; x=1733843487; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zREpKid1FijkM8w3fvUJYYcepCZqPc1/enXnI+QFhQI=; b=nOWsyZCRiDW1TCa7qYVbcYj4dlRrAhk8dbSDIOI4vRQkSVT44aldH/KR7SbC8Lzlka EQKIznGOuDSTDAQVxsXYDKshPE71LM9ZtkHDZ72dT6TNyoULkyAmVO9lQoL0f0idXZY5 cPVcdKiq9Znd1J76AY7MnIJWRh7aOaPYYVc566ixyWnCqy1nbDGv/dAvWtSVMaAi8OIr wXn/b0u+qCBMotorNaLRQkdsEnjCM0EwnqTalgz/+QKB5KQTwJGixQFLQPnrJeeCHtzI csSMIY+hWmpvn3pRnNoW0SC3Gg4zs5BZ+fn//jKvWBF1VvpxuarPExN7B4jYAuWsMDD0 zbAg== X-Forwarded-Encrypted: i=1; AJvYcCWl/Af5SiPSg/3Gla7x3UIWs1KZU3AsTaxv64UEtYBzQpP0Mmd1sjp3QMX3Yk7/t3808UuDHFeC6qY=@vger.kernel.org X-Gm-Message-State: AOJu0YyIs+pxxI1MDkF0PSt3u8nBpH3Qa+lesdn7kLgYnFglJ6WUxSU/ NwQpBf1AnYqj1exnkN3l4ONXMsu4aEfDwPixMExiNxsFH4U4MGuxZmLav5jV76Y= X-Gm-Gg: ASbGnctPrgIgo1RvNVChYF5OTTYjykhllDGSx5wiufjErQmY23S5LuO1Cdu7TW5QlzM lkyn/OecX/x1IYggZU0u0vVe9qed8Cho/z6RTZiuS6xbWtwdE21rr0qhgEZQUChDm2xV76ltXJO iuQL1HQ0LQgMb8o6V6X1KM6JoeOO13az4uET5DEsetAN948bgrvFExIgkufiIeVOEhHiacontP0 Ti92vHSetbm7jRflS2rM0V+ErU4bXQMccApqKfMhjQ2x8/YterB2Go07mWzcw== X-Google-Smtp-Source: AGHT+IHpG+YYkt5XvDCdFdtRCKt3GJs9wG1S7RmUFMFyXfoO+hh7Lfjm2kqMdLvybUfLqLTQRDejCw== X-Received: by 2002:a05:600c:3ca7:b0:431:12a8:7f1a with SMTP id 5b1f17b1804b1-434d09c12bfmr28153625e9.16.1733238687261; Tue, 03 Dec 2024 07:11:27 -0800 (PST) Received: from linaro.org ([2a02:2454:ff21:ef80:41ad:5703:2486:8f59]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434b0dc99b3sm191481505e9.24.2024.12.03.07.11.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 07:11:26 -0800 (PST) Date: Tue, 3 Dec 2024 16:11:22 +0100 From: Stephan Gerhold To: Abel Vesa , Johan Hovold Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krishna Kurapati , Thinh Nguyen , linux-usb@vger.kernel.org, Dmitry Baryshkov Subject: Re: [PATCH 1/2] arm64: dts: qcom: x1e80100-crd: Add USB multiport fingerprint readery Message-ID: References: <20241118-x1e80100-crd-fp-v1-0-ec6b553a2e53@linaro.org> <20241118-x1e80100-crd-fp-v1-1-ec6b553a2e53@linaro.org> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: +Cc Dmitry On Tue, Dec 03, 2024 at 02:03:05PM +0200, Abel Vesa wrote: > On 24-12-03 12:30:37, Stephan Gerhold wrote: > > On Tue, Dec 03, 2024 at 11:20:48AM +0100, Johan Hovold wrote: > > > [ +CC: Krishna, Thinh and the USB list ] > > > > > > On Mon, Nov 18, 2024 at 11:34:29AM +0100, Stephan Gerhold wrote: > > > > The X1E80100 CRD has a Goodix fingerprint reader connected to the USB > > > > multiport controller on eUSB6. All other ports (including USB super-speed > > > > pins) are unused. > > > > > > > > Set it up in the device tree together with the NXP PTN3222 repeater. > > > > > > > > Signed-off-by: Stephan Gerhold > > > > --- > > > > arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 48 +++++++++++++++++++++++++++++++ > > > > 1 file changed, 48 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts > > > > index 39f9d9cdc10d..44942931c18f 100644 > > > > --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts > > > > +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts > > > > @@ -735,6 +735,26 @@ keyboard@3a { > > > > }; > > > > }; > > > > > > > > +&i2c5 { > > > > + clock-frequency = <400000>; > > > > + > > > > + status = "okay"; > > > > + > > > > + eusb6_repeater: redriver@4f { > > > > + compatible = "nxp,ptn3222"; > > > > + reg = <0x4f>; > > > > > > The driver does not currently check that there's actually anything at > > > this address. Did you verify that this is the correct address? > > > > > > (Abel is adding a check to the driver as we speak to catch any such > > > mistakes going forward). > > > > > > > Yes, I verified this using > > https://git.codelinaro.org/stephan.gerhold/linux/-/commit/45d5add498612387f88270ca944ee16e2236fddd > > > > (I sent this to Abel back then, so I'm surprised he didn't run that :-)) > > I don't remember seeing this commit back then. Maybe I didn't look > careful enough. Sorry. > > Since you already did the work, can you send that on the list? > Sure, no problem. What exactly do we want for upstream? My patch above isn't ideal, because it checks the CHIP_ID on every PHY power up. But briefly powering up the PHY during probe() just for reading the CHIP_ID is also a bit weird. Not sure what the best approach here is. Thanks, Stephan