Re: [PATCH] driver/platform/chrome: Update cros_ec_trace with new USCI commands

Gwendal Grignou
2025-01-06T18:43:32Z

On Sat, Jan 4, 2025 at 12:13 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Jan 03, 2025 at 03:34:07PM -0800, Gwendal Grignou wrote:
> > Add this patch to "platform/chrome: Update ChromeOS EC header for UCSI"
>
> I do not understand this changelog text, sorry. How can you "add"
> something to an existing change?
>
> > to add the new commands form cros_ec_commands.h in the tracer so that
> > they are nicely decoded. Enable the tracer with:
> > cd /sys/kernel/debug/tracing
> > echo 1 > events/cros_ec/enable
> > echo 1 > tracing_on
> > cat trace_pipe
>
> We don't need to document how to enable a tracepoint here in the
> changelog, right? That's going to get lost and why is this new one
> somehow special?
>
> confused,
Sorry, I did not use `git send-email` appropriately: the code snippet
inside the email was not meant to be a standalone patch, but to be
added to patch v12 1/2 "platform/chrome: Update ChromeOS EC header for
UCSI".
If this is too late, that's fine; I will send a proper kernel patch
through the chrome-platform@lists.linux.dev mailing list.

Gwendal.
>
> greg k-h