Re: [PATCH] driver/platform/chrome: Update cros_ec_trace with new USCI commands

kernel test robot
2025-01-04T16:28:04Z

Hi Gwendal,

kernel test robot noticed the following build errors:

[auto build test ERROR on chrome-platform/for-next]
[also build test ERROR on chrome-platform/for-firmware-next linus/master v6.13-rc5 next-20241220]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Gwendal-Grignou/driver-platform-chrome-Update-cros_ec_trace-with-new-USCI-commands/20250104-073614
base: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next
patch link: https://lore.kernel.org/r/20250103233407.4001046-1-gwendal%40chromium.org
patch subject: [PATCH] driver/platform/chrome: Update cros_ec_trace with new USCI commands
config: x86_64-buildonly-randconfig-005-20250104 (https://download.01.org/0day-ci/archive/20250105/202501050055.oR3g1RHJ-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250105/202501050055.oR3g1RHJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501050055.oR3g1RHJ-lkp@intel.com/

All errors (new ones prefixed by >>):

In file included from drivers/platform/chrome/cros_ec_trace.c:217:
In file included from drivers/platform/chrome/cros_ec_trace.h:83:
In file included from include/trace/define_trace.h:113:
In file included from include/trace/trace_events.h:256:
>> drivers/platform/chrome/cros_ec_trace.h:40:40: error: use of undeclared identifier 'EC_CMD_UCSI_PPM_SET'
40 | __print_symbolic(__entry->command, EC_CMDS),
| ^
drivers/platform/chrome/cros_ec_trace.c:169:15: note: expanded from macro 'EC_CMDS'
169 | TRACE_SYMBOL(EC_CMD_UCSI_PPM_SET), \
| ^
In file included from drivers/platform/chrome/cros_ec_trace.c:217:
In file included from drivers/platform/chrome/cros_ec_trace.h:83:
In file included from include/trace/define_trace.h:113:
In file included from include/trace/trace_events.h:256:
>> drivers/platform/chrome/cros_ec_trace.h:40:40: error: use of undeclared identifier 'EC_CMD_UCSI_PPM_GET'
drivers/platform/chrome/cros_ec_trace.c:170:15: note: expanded from macro 'EC_CMDS'
170 | TRACE_SYMBOL(EC_CMD_UCSI_PPM_GET), \
| ^
In file included from drivers/platform/chrome/cros_ec_trace.c:217:
In file included from drivers/platform/chrome/cros_ec_trace.h:83:
In file included from include/trace/define_trace.h:113:
In file included from include/trace/trace_events.h:256:
drivers/platform/chrome/cros_ec_trace.h:67:40: error: use of undeclared identifier 'EC_CMD_UCSI_PPM_SET'
67 | __print_symbolic(__entry->command, EC_CMDS),
| ^
drivers/platform/chrome/cros_ec_trace.c:169:15: note: expanded from macro 'EC_CMDS'
169 | TRACE_SYMBOL(EC_CMD_UCSI_PPM_SET), \
| ^
In file included from drivers/platform/chrome/cros_ec_trace.c:217:
In file included from drivers/platform/chrome/cros_ec_trace.h:83:
In file included from include/trace/define_trace.h:113:
In file included from include/trace/trace_events.h:256:
drivers/platform/chrome/cros_ec_trace.h:67:40: error: use of undeclared identifier 'EC_CMD_UCSI_PPM_GET'
drivers/platform/chrome/cros_ec_trace.c:170:15: note: expanded from macro 'EC_CMDS'
170 | TRACE_SYMBOL(EC_CMD_UCSI_PPM_GET), \
| ^
4 errors generated.

vim +/EC_CMD_UCSI_PPM_SET +40 drivers/platform/chrome/cros_ec_trace.h

58a2109f6eb46b Raul E Rangel 2019-04-16 20
205c9326fd8665 Raul E Rangel 2019-11-25 21 TRACE_EVENT(cros_ec_request_start,
58a2109f6eb46b Raul E Rangel 2019-04-16 22 TP_PROTO(struct cros_ec_command *cmd),
58a2109f6eb46b Raul E Rangel 2019-04-16 23 TP_ARGS(cmd),
58a2109f6eb46b Raul E Rangel 2019-04-16 24 TP_STRUCT__entry(
58a2109f6eb46b Raul E Rangel 2019-04-16 25 __field(uint32_t, version)
8143182426874a Gwendal Grignou 2020-08-14 26 __field(uint32_t, offset)
58a2109f6eb46b Raul E Rangel 2019-04-16 27 __field(uint32_t, command)
8143182426874a Gwendal Grignou 2020-08-14 28 __field(uint32_t, outsize)
8143182426874a Gwendal Grignou 2020-08-14 29 __field(uint32_t, insize)
58a2109f6eb46b Raul E Rangel 2019-04-16 30 ),
58a2109f6eb46b Raul E Rangel 2019-04-16 31 TP_fast_assign(
58a2109f6eb46b Raul E Rangel 2019-04-16 32 __entry->version = cmd->version;
3db0c9e5de7bd9 Tzung-Bi Shih 2022-06-09 33 __entry->offset = cmd->command / EC_CMD_PASSTHRU_OFFSET(CROS_EC_DEV_PD_INDEX);
3db0c9e5de7bd9 Tzung-Bi Shih 2022-06-09 34 __entry->command = cmd->command % EC_CMD_PASSTHRU_OFFSET(CROS_EC_DEV_PD_INDEX);
8143182426874a Gwendal Grignou 2020-08-14 35 __entry->outsize = cmd->outsize;
8143182426874a Gwendal Grignou 2020-08-14 36 __entry->insize = cmd->insize;
58a2109f6eb46b Raul E Rangel 2019-04-16 37 ),
8143182426874a Gwendal Grignou 2020-08-14 38 TP_printk("version: %u, offset: %d, command: %s, outsize: %u, insize: %u",
8143182426874a Gwendal Grignou 2020-08-14 39 __entry->version, __entry->offset,
8143182426874a Gwendal Grignou 2020-08-14 @40 __print_symbolic(__entry->command, EC_CMDS),
8143182426874a Gwendal Grignou 2020-08-14 41 __entry->outsize, __entry->insize)
58a2109f6eb46b Raul E Rangel 2019-04-16 42 );
58a2109f6eb46b Raul E Rangel 2019-04-16 43

--
0-DAY CI Kernel Test Service