Re: [PATCH] dt-bindings: usb: usb-device: Add panel-location

Sakari Ailus
2025-01-08T09:13:09Z

Hi Ricardo,

On Wed, Jan 08, 2025 at 09:51:34AM +0100, Ricardo Ribalda wrote:
> > > diff --git a/Documentation/devicetree/bindings/usb/usb-device.yaml
> > > b/Documentation/devicetree/bindings/usb/usb-device.yaml
> > > index da890ee60ce6..5322772a4470 100644
> > > --- a/Documentation/devicetree/bindings/usb/usb-device.yaml
> > > +++ b/Documentation/devicetree/bindings/usb/usb-device.yaml
> > > @@ -37,6 +37,10 @@ properties:
> > > but a device adhering to this binding may leave out all except
> > > for "usbVID,PID".
> > >
> > > + orientation:
> > > + description: If present, specifies the orientation of the usb device.
> > > + $ref: /schemas/media/video-interface-devices.yaml#/properties/orientation
> >
> > Do you need this for a camera or for other kinds of USB devices, too?
> >
> > What about e.g. the rotation property?
>
> I need it for cameras. I do not have a usecase for rotation now, but I
> might have in the future.

If it's specific for cameras (UVC kind I presume?), wouldn't it be
reasonable to add specific bindings for it?

--
Sakari Ailus