Re: [PATCH 1/2] usb: typec: thunderbolt: Fix loops that iterate TYPEC_PLUG_SOP_P and TYPEC_PLUG_SOP_PP

[Benson Leung <bleung@google.com>]

[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]

Hi Greg,

On Mon, Feb 03, 2025 at 04:18:28PM +0100, Greg KH wrote:
> On Fri, Jan 24, 2025 at 07:40:23PM +0000, Benson Leung wrote:
> > Fixes these Smatch static checker warnings:
> > drivers/usb/typec/altmodes/thunderbolt.c:116 tbt_altmode_work() warn: why is zero skipped 'i'
> > drivers/usb/typec/altmodes/thunderbolt.c:147 tbt_enter_modes_ordered() warn: why is zero skipped 'i'
> > drivers/usb/typec/altmodes/thunderbolt.c:328 tbt_altmode_remove() warn: why is zero skipped 'i'
> > 
> > Fixes: 100e25738659 ("usb: typec: Add driver for Thunderbolt 3 Alternate Mode")
> > 
> > Signed-off-by: Benson Leung <bleung@chromium.org>
> > Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> > ---
> >  drivers/usb/typec/altmodes/thunderbolt.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Please always use 'git send-email' or if not, manually thread your
> patches so they all show up together as a series.  These are both
> individual and as such, don't play nice with tools.

Sorry about that. I still need to set up my git-send-email workflow on this new
cloud workstation, and I'll get that rectified for next time.

> 
> I'll try to manually handle them, but you owe me...

Thanks! I'll definitely owe you one.

> 
> thanks,
> 
> greg k-h

Benson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]