Re: [PATCH v2 1/5] driver core: add a faux bus for use when a simple device/bus is needed

Greg Kroah-Hartman
2025-02-05T05:52:01Z

On Tue, Feb 04, 2025 at 05:51:25PM -0500, Lyude Paul wrote:
> Oops! I actually caught one small nitpick I didn't notice before when writing
> up the bindings:
>
> On Tue, 2025-02-04 at 12:09 +0100, Greg Kroah-Hartman wrote:
> > +/**
> > + * faux_device_create - create and register a faux device and driver
> > + * @name: name of the device and driver we are adding
> > + * @faux_ops: struct faux_driver_ops that the new device will call back into, can be NULL
> > + *
> > + * Create a new faux device and driver, both with the same name, and
> > + * register them in the driver core properly.  The probe() callback of
> > + * @faux_ops will be called with the new device that is created for the
> > + * caller to do something with.
> > + *
> > + * Note, when this function is called, the functions specified in struct
> > + * faux_ops will be called before the function returns, so be prepared for
> > + * everything to be properly initialized before that point in time.
> > + *
> > + * Return:
> > + * * NULL if an error happened with creating the device
> > + * * pointer to a valid struct faux_device that is registered with sysfs
> > + */
> > +struct faux_device *faux_device_create(const char *name, struct faux_driver_ops *faux_ops)
>
> ^ Why not const struct faux_driver_ops? Doesn't seem like there's any need to
> mutate faux_ops.

Yes, Rob also pointed this out, I'll make this change, and the
documentation updates, later today.

thanks,

greg k-h