From: Johan Hovold <johan@kernel.org>
To: Tony Chung <tony467913@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 5/6] drivers: usb: serial: mos7840: replace 'unsigned' w/ 'unsigned int'
Date: Tue, 11 Feb 2025 10:31:06 +0100 [thread overview]
Message-ID: <Z6sY2lO3lmFCrKeb@hovoldconsulting.com> (raw)
In-Reply-To: <20241025061711.198933-6-tony467913@gmail.com>
On Fri, Oct 25, 2024 at 02:17:16PM +0800, Tony Chung wrote:
> Fix coding style "Prefer 'unsigned int' to bare use of 'unsigned'"
>
> Signed-off-by: Tony Chung <tony467913@gmail.com>
> ---
> drivers/usb/serial/mos7840.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> index 31ec2cf1b..d2cae6619 100644
> --- a/drivers/usb/serial/mos7840.c
> +++ b/drivers/usb/serial/mos7840.c
> @@ -1201,7 +1201,7 @@ static void mos7840_change_port_settings(struct tty_struct *tty,
> {
> struct usb_serial_port *port = mos7840_port->port;
> int baud;
> - unsigned cflag;
> + unsigned int cflag;
Just drop this one too.
You can follow this style suggestion in your own code, but there's
really no need to go around changing perfectly valid code just to
silence checkpatch.
Johan
next prev parent reply other threads:[~2025-02-11 9:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 9:14 [PATCH] usb: serial: mos7840: Fix coding style warnings Tony Chung
2024-10-23 10:04 ` Greg KH
2024-10-24 17:37 ` kernel test robot
2024-10-24 17:58 ` kernel test robot
2024-10-25 6:17 ` [PATCH v2 0/6] " Tony Chung
2025-02-11 9:15 ` Johan Hovold
2024-10-25 6:17 ` [PATCH v2 1/6] driver: usb: serial: mos7840: fix " Tony Chung
2025-02-11 9:20 ` Johan Hovold
2024-10-25 6:17 ` [PATCH v2 2/6] drivers: usb: serial: mos7840: Fix Block comments coding " Tony Chung
2025-02-11 9:27 ` Johan Hovold
2024-10-25 6:17 ` [PATCH v2 3/6] drivers: usb: serial: mos7840: fix " Tony Chung
2025-02-11 9:28 ` Johan Hovold
2024-10-25 6:17 ` [PATCH v2 4/6] drivers: usb: serial: mos7840: using '__func__' to replace function name in dbg message Tony Chung
2025-02-11 9:29 ` Johan Hovold
2025-02-11 9:32 ` Greg KH
2025-02-11 9:38 ` Johan Hovold
2024-10-25 6:17 ` [PATCH v2 5/6] drivers: usb: serial: mos7840: replace 'unsigned' w/ 'unsigned int' Tony Chung
2025-02-11 9:31 ` Johan Hovold [this message]
2024-10-25 6:17 ` [PATCH v2 6/6] drivers: usb: serial: mos7840: fix the quoted string split across lines Tony Chung
2025-02-11 9:32 ` Johan Hovold
2024-10-25 7:49 ` [PATCH] usb: serial: mos7840: Fix coding style warnings kernel test robot
2024-10-28 5:27 ` Tony Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6sY2lO3lmFCrKeb@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tony467913@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox