* [PATCH v4 2/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for MUX IT5205
2025-02-20 14:33 [PATCH v4 1/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for TCPC port Macpaul Lin
@ 2025-02-20 14:33 ` Macpaul Lin
2025-02-20 15:58 ` [PATCH v4 1/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for TCPC port AngeloGioacchino Del Regno
2025-02-20 21:29 ` Rob Herring (Arm)
2 siblings, 0 replies; 7+ messages in thread
From: Macpaul Lin @ 2025-02-20 14:33 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, Alexandre Mergnat
Cc: Bear Wang, Pablo Sun, Macpaul Lin, Macpaul Lin,
Project_Global_Chrome_Upstream_Group, linux-usb, Chris-qj chen,
Fabien Parent, Simon Sun
Add ITE IT5205 (TYPEC MUX) under I2C2 bus and configure its properties;
also add references to it5205fn from MT6360 TYPE-C connector for TYPEC
configuration.
Signed-off-by: Fabien Parent <fparent@baylibre.com>
Signed-off-by: Simon Sun <simon.sun@yunjingtech.com>
Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../dts/mediatek/mt8395-genio-1200-evk.dts | 22 +++++++++++++++++++
1 file changed, 22 insertions(+)
Changes for v2:
- This is a new patch in the v2 patch.
Changes for v3:
- No change.
Changes fo4 v4:
- Drop it5205fn phandle for node typec-mux@48.
- Reorder properties of typec-mux@48
- Add "Reviewed-by:" tag. Thanks!
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
index ca039c8e4c71..8ec5c4cf59f3 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
@@ -224,6 +224,21 @@ &i2c2 {
pinctrl-0 = <&i2c2_pins>;
pinctrl-names = "default";
status = "okay";
+
+ typec-mux@48 {
+ compatible = "ite,it5205";
+ reg = <0x48>;
+ vcc-supply = <&mt6359_vibr_ldo_reg>;
+ mode-switch;
+ orientation-switch;
+ status = "okay";
+
+ port {
+ it5205_sbu_ep: endpoint {
+ remote-endpoint = <&mt6360_ssusb_sbu_ep>;
+ };
+ };
+ };
};
&i2c6 {
@@ -368,6 +383,13 @@ typec_con_ss: endpoint {
remote-endpoint = <&mtu3_ss0_role_sw>;
};
};
+
+ port@2 {
+ reg = <2>;
+ mt6360_ssusb_sbu_ep: endpoint {
+ remote-endpoint = <&it5205_sbu_ep>;
+ };
+ };
};
};
};
--
2.45.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v4 1/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for TCPC port
2025-02-20 14:33 [PATCH v4 1/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for TCPC port Macpaul Lin
2025-02-20 14:33 ` [PATCH v4 2/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for MUX IT5205 Macpaul Lin
@ 2025-02-20 15:58 ` AngeloGioacchino Del Regno
2025-02-21 11:39 ` Macpaul Lin (林智斌)
2025-02-20 21:29 ` Rob Herring (Arm)
2 siblings, 1 reply; 7+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-02-20 15:58 UTC (permalink / raw)
To: Macpaul Lin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, Alexandre Mergnat
Cc: Bear Wang, Pablo Sun, Macpaul Lin,
Project_Global_Chrome_Upstream_Group, linux-usb, Chris-qj chen,
Fabien Parent, Yow-Shin Liou, Simon Sun
Il 20/02/25 15:33, Macpaul Lin ha scritto:
> From: Fabien Parent <fparent@baylibre.com>
>
> Enable USB Type-C support on MediaTek MT8395 Genio 1200 EVK by adding
> configuration for TCPC Port, USB-C connector, and related settings.
>
> Configure dual role switch capability, set up PD (Power Delivery) profiles,
> and establish endpoints for SS (SuperSpeed) and HS (HighSpeed) USB.
>
> Update pinctrl configurations for U3 P0 VBus default pins and set dr_mode
> to "otg" for OTG (On-The-Go) mode operation.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> Signed-off-by: Yow-Shin Liou <yow-shin.liou@mediatek.com>
> Signed-off-by: Simon Sun <simon.sun@yunjingtech.com>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
> .../dts/mediatek/mt8395-genio-1200-evk.dts | 72 +++++++++++++++++++
> 1 file changed, 72 insertions(+)
>
> Changes for v2:
> - Drop the no need '1/2' DT Schema update patch in the 1st version.
> - Fix indent for 'ports' node, it should under the 'connector' node.
> - Correct the index for 'port@0' and 'port@1' node.
>
> Changes for v3:
> - Correct the order between new added nodes.
>
> Changes for v4:
> - Reorder for property 'op-sink-microwatt'.
> - Fix indentation for 'source-pdos' and 'sink-pdos' nodes.
> - Correct node 'pin-cmd-dat' with 'pins-vbus'.
> - Add both Highspeed and Superspeed ports to ssusb0 port.
> - Set 'role-switch-default-mode' = "peripheral" for ssusb0 port.
> - Rename endpoint of USB data port to 'mtu3_hs0_role_sw' and
> 'mtu3_ss0_role_sw'.
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
> index 1ef6262b65c9..ca039c8e4c71 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
> @@ -330,6 +330,47 @@ mt6360_ldo7: ldo7 {
> regulator-always-on;
> };
> };
> +
> + tcpc {
> + compatible = "mediatek,mt6360-tcpc";
> + interrupts-extended = <&pio 17 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-names = "PD_IRQB";
> +
> + connector {
> + compatible = "usb-c-connector";
> + label = "USB-C";
> + data-role = "dual";
> + op-sink-microwatt = <10000000>;
> + power-role = "dual";
> + try-power-role = "sink";
Would be appreciated if you could also complete the node by adding the pd-revision
property, enabling full USBC Power Delivery for the MT6360 PMIC.
Same for the alternate modes, adding the DP alt mode is a matter of seconds... and
well, it does sound a bit weird to add alternate modes without a mux... so, in this
case you can choose either to:
- Squash the two commits (tcpc, it5205) and do everything in one; or
- Add the alternate mode node to the connector in the commit introducing the mux.
Either of the two options is okay for me, so you choose.
> +
> + source-pdos = <PDO_FIXED(5000, 1000,
> + PDO_FIXED_DUAL_ROLE |
> + PDO_FIXED_DATA_SWAP)>;
> + sink-pdos = <PDO_FIXED(5000, 2000,
> + PDO_FIXED_DUAL_ROLE |
> + PDO_FIXED_DATA_SWAP)>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + typec_con_hs: endpoint {
> + remote-endpoint = <&mtu3_hs0_role_sw>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + typec_con_ss: endpoint {
> + remote-endpoint = <&mtu3_ss0_role_sw>;
> + };
> + };
> + };
> + };
> + };
> };
> };
>
> @@ -755,6 +796,13 @@ pins-reset {
> };
> };
>
> + u3_p0_vbus: u3-p0-vbus-default-pins {
> + pins-vbus {
> + pinmux = <PINMUX_GPIO63__FUNC_VBUSVALID>;
> + input-enable;
> + };
> + };
> +
> uart0_pins: uart0-pins {
> pins {
> pinmux = <PINMUX_GPIO98__FUNC_UTXD0>,
> @@ -885,8 +933,32 @@ &ufsphy {
> };
>
> &ssusb0 {
> + dr_mode = "otg";
> + pinctrl-names = "default";
> + pinctrl-0 = <&u3_p0_vbus>;
> + role-switch-default-mode = "peripheral";
There's no need for a default mode here, luckily the MediaTek MTU3 controllers
don't need that for real :-)
Drop please.
Cheers,
Angelo
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v4 1/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for TCPC port
2025-02-20 15:58 ` [PATCH v4 1/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for TCPC port AngeloGioacchino Del Regno
@ 2025-02-21 11:39 ` Macpaul Lin (林智斌)
2025-02-24 1:54 ` ChiYuan Huang
0 siblings, 1 reply; 7+ messages in thread
From: Macpaul Lin (林智斌) @ 2025-02-21 11:39 UTC (permalink / raw)
To: linux-mediatek@lists.infradead.org, cy_huang@richtek.com,
devicetree@vger.kernel.org, robh@kernel.org,
linux-kernel@vger.kernel.org, krzk+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno,
conor+dt@kernel.org, matthias.bgg@gmail.com, Alexandre Mergnat
Cc: fparent@baylibre.com,
Bear Wang (萩原惟德),
linux-usb@vger.kernel.org, Project_Global_Chrome_Upstream_Group,
macpaul@gmail.com, Pablo Sun (孫毓翔),
simon.sun@yunjingtech.com,
Yow-shin Liou (劉祐炘),
Chris-qj Chen (陳奇進)
On Thu, 2025-02-20 at 16:58 +0100, AngeloGioacchino Del Regno wrote:
>
>
[snip]
> > + tcpc {
> > + compatible = "mediatek,mt6360-tcpc";
> > + interrupts-extended = <&pio 17
> > IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-names = "PD_IRQB";
> > +
> > + connector {
> > + compatible = "usb-c-connector";
> > + label = "USB-C";
> > + data-role = "dual";
> > + op-sink-microwatt = <10000000>;
> > + power-role = "dual";
> > + try-power-role = "sink";
>
> Would be appreciated if you could also complete the node by adding
> the pd-revision
> property, enabling full USBC Power Delivery for the MT6360 PMIC.
>
Well, I have no idea about the pd-revision of MT6360.
I could found MT6360 supports PD 3.0 according to the datasheet,
however, I have no idea about the other fields like major and minor
values. Dear ChiYuan, could you help to provide the value of pd-
revision? The property has been defined in
Documentation/devicetree/bindings/connector/usb-connector.yaml.
> Same for the alternate modes, adding the DP alt mode is a matter of
> seconds... and
> well, it does sound a bit weird to add alternate modes without a
> mux... so, in this
> case you can choose either to:
> - Squash the two commits (tcpc, it5205) and do everything in one;
> or
> - Add the alternate mode node to the connector in the commit
> introducing the mux.
>
> Either of the two options is okay for me, so you choose.
> >
Well, I could squash the two commits together and adding the DP alt
mode values in next version.
> >
> > &ssusb0 {
> > + dr_mode = "otg";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&u3_p0_vbus>;
> > + role-switch-default-mode = "peripheral";
>
> There's no need for a default mode here, luckily the MediaTek MTU3
> controllers
> don't need that for real :-)
Okay, will drop it than.
Thanks.
Macpaul Lin
> Drop please.
>
> Cheers,
> Angelo
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v4 1/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for TCPC port
2025-02-21 11:39 ` Macpaul Lin (林智斌)
@ 2025-02-24 1:54 ` ChiYuan Huang
2025-02-24 8:54 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 7+ messages in thread
From: ChiYuan Huang @ 2025-02-24 1:54 UTC (permalink / raw)
To: Macpaul Lin (林智斌)
Cc: linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
robh@kernel.org, linux-kernel@vger.kernel.org, krzk+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno,
conor+dt@kernel.org, matthias.bgg@gmail.com, Alexandre Mergnat,
fparent@baylibre.com,
Bear Wang (萩原惟德),
linux-usb@vger.kernel.org, Project_Global_Chrome_Upstream_Group,
macpaul@gmail.com, Pablo Sun (孫毓翔),
simon.sun@yunjingtech.com,
Yow-shin Liou (劉祐炘),
Chris-qj Chen (陳奇進)
On Fri, Feb 21, 2025 at 11:39:09AM +0000, Macpaul Lin (林智斌) wrote:
> On Thu, 2025-02-20 at 16:58 +0100, AngeloGioacchino Del Regno wrote:
> >
> >
>
> [snip]
>
> > > + tcpc {
> > > + compatible = "mediatek,mt6360-tcpc";
> > > + interrupts-extended = <&pio 17
> > > IRQ_TYPE_LEVEL_LOW>;
> > > + interrupt-names = "PD_IRQB";
> > > +
> > > + connector {
> > > + compatible = "usb-c-connector";
> > > + label = "USB-C";
> > > + data-role = "dual";
> > > + op-sink-microwatt = <10000000>;
> > > + power-role = "dual";
> > > + try-power-role = "sink";
> >
> > Would be appreciated if you could also complete the node by adding
> > the pd-revision
> > property, enabling full USBC Power Delivery for the MT6360 PMIC.
> >
>
> Well, I have no idea about the pd-revision of MT6360.
> I could found MT6360 supports PD 3.0 according to the datasheet,
> however, I have no idea about the other fields like major and minor
> values. Dear ChiYuan, could you help to provide the value of pd-
> revision? The property has been defined in
> Documentation/devicetree/bindings/connector/usb-connector.yaml.
>
Hi, Macpaul:
You can specify the version information to 3.1 version 1.6.
Just add the below property into the 'connector' node.
pd-revision = /bits/ 8 <0x03 0x01 0x01 0x06>;
Regards,
ChiYuan
......
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v4 1/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for TCPC port
2025-02-24 1:54 ` ChiYuan Huang
@ 2025-02-24 8:54 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 7+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-02-24 8:54 UTC (permalink / raw)
To: ChiYuan Huang, Macpaul Lin (林智斌)
Cc: linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
robh@kernel.org, linux-kernel@vger.kernel.org, krzk+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, conor+dt@kernel.org,
matthias.bgg@gmail.com, Alexandre Mergnat, fparent@baylibre.com,
Bear Wang (萩原惟德),
linux-usb@vger.kernel.org, Project_Global_Chrome_Upstream_Group,
macpaul@gmail.com, Pablo Sun (孫毓翔),
simon.sun@yunjingtech.com,
Yow-shin Liou (劉祐炘),
Chris-qj Chen (陳奇進)
Il 24/02/25 02:54, ChiYuan Huang ha scritto:
> On Fri, Feb 21, 2025 at 11:39:09AM +0000, Macpaul Lin (林智斌) wrote:
>> On Thu, 2025-02-20 at 16:58 +0100, AngeloGioacchino Del Regno wrote:
>>>
>>>
>>
>> [snip]
>>
>>>> + tcpc {
>>>> + compatible = "mediatek,mt6360-tcpc";
>>>> + interrupts-extended = <&pio 17
>>>> IRQ_TYPE_LEVEL_LOW>;
>>>> + interrupt-names = "PD_IRQB";
>>>> +
>>>> + connector {
>>>> + compatible = "usb-c-connector";
>>>> + label = "USB-C";
>>>> + data-role = "dual";
>>>> + op-sink-microwatt = <10000000>;
>>>> + power-role = "dual";
>>>> + try-power-role = "sink";
>>>
>>> Would be appreciated if you could also complete the node by adding
>>> the pd-revision
>>> property, enabling full USBC Power Delivery for the MT6360 PMIC.
>>>
>>
>> Well, I have no idea about the pd-revision of MT6360.
>> I could found MT6360 supports PD 3.0 according to the datasheet,
>> however, I have no idea about the other fields like major and minor
>> values. Dear ChiYuan, could you help to provide the value of pd-
>> revision? The property has been defined in
>> Documentation/devicetree/bindings/connector/usb-connector.yaml.
>>
> Hi, Macpaul:
>
> You can specify the version information to 3.1 version 1.6.
> Just add the below property into the 'connector' node.
>
> pd-revision = /bits/ 8 <0x03 0x01 0x01 0x06>;
>
> Regards,
> ChiYuan
Thanks ChiYuan, that's great to know.
With this - all boards relying on MT6360 can charge use the full set of supported
USB Power Delivery capabilities (that, since the PD revision is specific to the
MT6360 TCPC, and not board specific!).
Macpaul, please add the pd-revision as suggested, and for v6, please add my:
Reviewed-By: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cheers!
Angelo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4 1/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for TCPC port
2025-02-20 14:33 [PATCH v4 1/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for TCPC port Macpaul Lin
2025-02-20 14:33 ` [PATCH v4 2/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for MUX IT5205 Macpaul Lin
2025-02-20 15:58 ` [PATCH v4 1/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for TCPC port AngeloGioacchino Del Regno
@ 2025-02-20 21:29 ` Rob Herring (Arm)
2 siblings, 0 replies; 7+ messages in thread
From: Rob Herring (Arm) @ 2025-02-20 21:29 UTC (permalink / raw)
To: Macpaul Lin
Cc: linux-arm-kernel, Conor Dooley, linux-kernel, Yow-Shin Liou,
Project_Global_Chrome_Upstream_Group, Simon Sun, Matthias Brugger,
Alexandre Mergnat, AngeloGioacchino Del Regno, Chris-qj chen,
devicetree, linux-mediatek, Pablo Sun, Macpaul Lin, linux-usb,
Fabien Parent, Krzysztof Kozlowski, Bear Wang
On Thu, 20 Feb 2025 22:33:53 +0800, Macpaul Lin wrote:
> From: Fabien Parent <fparent@baylibre.com>
>
> Enable USB Type-C support on MediaTek MT8395 Genio 1200 EVK by adding
> configuration for TCPC Port, USB-C connector, and related settings.
>
> Configure dual role switch capability, set up PD (Power Delivery) profiles,
> and establish endpoints for SS (SuperSpeed) and HS (HighSpeed) USB.
>
> Update pinctrl configurations for U3 P0 VBus default pins and set dr_mode
> to "otg" for OTG (On-The-Go) mode operation.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> Signed-off-by: Yow-Shin Liou <yow-shin.liou@mediatek.com>
> Signed-off-by: Simon Sun <simon.sun@yunjingtech.com>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
> .../dts/mediatek/mt8395-genio-1200-evk.dts | 72 +++++++++++++++++++
> 1 file changed, 72 insertions(+)
>
> Changes for v2:
> - Drop the no need '1/2' DT Schema update patch in the 1st version.
> - Fix indent for 'ports' node, it should under the 'connector' node.
> - Correct the index for 'port@0' and 'port@1' node.
>
> Changes for v3:
> - Correct the order between new added nodes.
>
> Changes for v4:
> - Reorder for property 'op-sink-microwatt'.
> - Fix indentation for 'source-pdos' and 'sink-pdos' nodes.
> - Correct node 'pin-cmd-dat' with 'pins-vbus'.
> - Add both Highspeed and Superspeed ports to ssusb0 port.
> - Set 'role-switch-default-mode' = "peripheral" for ssusb0 port.
> - Rename endpoint of USB data port to 'mtu3_hs0_role_sw' and
> 'mtu3_ss0_role_sw'.
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/mediatek/' for 20250220143354.2532448-1-macpaul.lin@mediatek.com:
arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dtb: usb@11201000: 'ports' does not match any of the regexes: '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/usb/mediatek,mtu3.yaml#
^ permalink raw reply [flat|nested] 7+ messages in thread