From: Abhishek Tamboli <abhishektamboli9@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, dan.carpenter@linaro.org
Subject: Re: [PATCH] xhci: Fix bcdUSB initialization
Date: Fri, 28 Feb 2025 01:41:20 +0530 [thread overview]
Message-ID: <Z8DG6A76HFWs3hlD@embed-PC> (raw)
In-Reply-To: <2025022757-extrude-carpenter-5bec@gregkh>
Hi Greg,
Thanks for the review.
> On Fri, Feb 28, 2025 at 01:04:00AM +0530, Abhishek Tamboli wrote:
> > Initialize bcdUSB to 0 to prevent undefined behaviour
> > if accessed without being explicitly set.
>
> Is it actually accessed without being set? If so, please explain it and
> also how the compiler is somehow missing this already?
I added bcdUSB = 0 based on a Smatch warning about potential uninitialized access.
However, given that bcdUSB is always set in the first loop iteration,
this might be a false positive.
Regards,
Abhishek
next prev parent reply other threads:[~2025-02-27 20:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 19:34 [PATCH] xhci: Fix bcdUSB initialization Abhishek Tamboli
2025-02-27 19:36 ` Greg KH
2025-02-27 20:11 ` Abhishek Tamboli [this message]
2025-02-27 20:16 ` Dan Carpenter
2025-02-27 20:15 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8DG6A76HFWs3hlD@embed-PC \
--to=abhishektamboli9@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox