From: Johan Hovold <johan@kernel.org>
To: "Ng, Boon Khai" <boon.khai.ng@altera.com>
Cc: Boon Khai Ng <boon.khai.ng@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb <linux-usb@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Ang, Tien Sung" <tien.sung.ang@altera.com>
Subject: Re: [PATCH v3] USB: serial: ftdi_sio: add support for Altera USB Blaster 3
Date: Fri, 14 Mar 2025 08:24:01 +0100 [thread overview]
Message-ID: <Z9PZkX12YX1sbvSt@hovoldconsulting.com> (raw)
In-Reply-To: <BN8PR03MB507362B42C47E2D3FF7C2D7CB4D22@BN8PR03MB5073.namprd03.prod.outlook.com>
On Fri, Mar 14, 2025 at 02:14:47AM +0000, Ng, Boon Khai wrote:
> > Thanks for the update, now applied.
> >
> > Next time, remember to put your SoB above the (first) cut-off line (---) so that
> > it is included in the commit message when your patch is applied.
> > I fixed that up manually this time.
>
> Thank you for your feedback and for applying the update.
> I apologize for the misunderstanding regarding the placement of the SoB.
> I mistakenly thought I needed to create the cut-off line myself in the
> commit message.
No worries.
> I now understand that I should generate the patch first and then
> manually add the change log under the first cut-off line that
> appears below the sign-off.
That's what I do, but if you add your SoB followed by a cut-off line and
change log to your local commit, then that should also work if you later
run git-format-patch.
Johan
next prev parent reply other threads:[~2025-03-14 7:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 3:05 [PATCH v3] USB: serial: ftdi_sio: add support for Altera USB Blaster 3 Boon Khai Ng
2025-03-12 16:57 ` Johan Hovold
2025-03-14 2:14 ` Ng, Boon Khai
2025-03-14 7:24 ` Johan Hovold [this message]
2025-03-17 1:48 ` Ng, Boon Khai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9PZkX12YX1sbvSt@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=boon.khai.ng@altera.com \
--cc=boon.khai.ng@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tien.sung.ang@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox