From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bastien Nocera <hadess@hadess.net>
Cc: linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
"Alan Stern" <stern@rowland.harvard.edu>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Filipe Laíns" <lains@riseup.net>,
"Nestor Lopez Casado" <nlopezcasad@logitech.com>
Subject: Re: [PATCH v3 1/6] HID: logitech-hidpp: Simplify array length check
Date: Thu, 9 Mar 2023 15:18:13 +0100 [thread overview]
Message-ID: <ZAnqpZhFuiIQeFBk@kroah.com> (raw)
In-Reply-To: <20230302105555.51417-1-hadess@hadess.net>
On Thu, Mar 02, 2023 at 11:55:50AM +0100, Bastien Nocera wrote:
> Use the compiler to force a 100-length array, rather than check the
> length after the fact.
>
> Signed-off-by: Bastien Nocera <hadess@hadess.net>
> ---
> New in v2, following a review comment in the 1f20 enablement patch.
> No changes in v3.
>
> drivers/hid/hid-logitech-hidpp.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
These all look good to me, and probably should go through the HID tree,
so I've acked the USB-specific ones to allow that.
thanks,
greg k-h
next prev parent reply other threads:[~2023-03-09 14:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 10:55 [PATCH v3 1/6] HID: logitech-hidpp: Simplify array length check Bastien Nocera
2023-03-02 10:55 ` [PATCH v3 2/6] HID: logitech-hidpp: Add support for ADC measurement feature Bastien Nocera
2023-03-02 10:55 ` [PATCH v3 3/6] HID: logitech-hidpp: Add Logitech G935 headset Bastien Nocera
2023-03-02 10:55 ` [PATCH v3 4/6] USB: core: Add wireless_status sysfs attribute Bastien Nocera
2023-03-02 15:27 ` Alan Stern
2023-03-09 14:17 ` Greg Kroah-Hartman
2023-03-02 10:55 ` [PATCH v3 5/6] USB: core: Add API to change the wireless_status Bastien Nocera
2023-03-09 14:17 ` Greg Kroah-Hartman
2023-03-02 10:55 ` [PATCH v3 6/6] HID: logitech-hidpp: Set wireless_status for G935 receiver Bastien Nocera
2023-03-09 14:18 ` Greg Kroah-Hartman [this message]
2023-04-03 13:33 ` [PATCH v3 1/6] HID: logitech-hidpp: Simplify array length check Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAnqpZhFuiIQeFBk@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benjamin.tissoires@redhat.com \
--cc=hadess@hadess.net \
--cc=lains@riseup.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nlopezcasad@logitech.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).