From: Greg KH <gregkh@linuxfoundation.org>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: mirsad.todorovac@alu.unizg.hr, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
ubuntu-devel-discuss@lists.ubuntu.com, stern@rowland.harvard.edu,
arnd@arndb.de, Stable@vger.kernel.org
Subject: Re: [PATCH] xhci: Free the command allocated for setting LPM if we return early
Date: Mon, 27 Mar 2023 13:51:34 +0200 [thread overview]
Message-ID: <ZCGDRrT4Bo3-UYOZ@kroah.com> (raw)
In-Reply-To: <20230327095019.1017159-1-mathias.nyman@linux.intel.com>
On Mon, Mar 27, 2023 at 12:50:19PM +0300, Mathias Nyman wrote:
> The command allocated to set exit latency LPM values need to be freed in
> case the command is never queued. This would be the case if there is no
> change in exit latency values, or device is missing.
>
> Fixes: 5c2a380a5aa8 ("xhci: Allocate separate command structures for each LPM command")
> Cc: <Stable@vger.kernel.org>
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> ---
> drivers/usb/host/xhci.c | 1 +
> 1 file changed, 1 insertion(+)
Do you want me to take this now, or will you be sending this to me in a
separate series of xhci fixes? Either is fine with me.
thanks,
greg k-h
next prev parent reply other threads:[~2023-03-27 11:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 11:27 BUG: drivers/usb/host/xhci: memleak in alloc from xhci_disable_usb3_lpm_timeout() Mirsad Goran Todorovac
2023-03-25 11:33 ` Mirsad Goran Todorovac
2023-03-27 9:41 ` Mathias Nyman
2023-03-27 9:50 ` [PATCH] xhci: Free the command allocated for setting LPM if we return early Mathias Nyman
2023-03-27 11:51 ` Greg KH [this message]
2023-03-27 13:31 ` Mathias Nyman
2023-03-27 15:46 ` Mirsad Goran Todorovac
2023-03-27 22:25 ` Mirsad Goran Todorovac
2023-03-28 7:57 ` Mathias Nyman
2023-04-03 9:20 ` Mirsad Goran Todorovac
2023-03-27 12:04 ` BUG: drivers/usb/host/xhci: memleak in alloc from xhci_disable_usb3_lpm_timeout() Mirsad Goran Todorovac
2023-03-27 22:07 ` BUG: BISECTED: " Mirsad Goran Todorovac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCGDRrT4Bo3-UYOZ@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Stable@vger.kernel.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=mirsad.todorovac@alu.unizg.hr \
--cc=stern@rowland.harvard.edu \
--cc=ubuntu-devel-discuss@lists.ubuntu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).