From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F93EC77B76 for ; Mon, 17 Apr 2023 14:19:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229929AbjDQOTf (ORCPT ); Mon, 17 Apr 2023 10:19:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230085AbjDQOTe (ORCPT ); Mon, 17 Apr 2023 10:19:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A03B597; Mon, 17 Apr 2023 07:19:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 313546259D; Mon, 17 Apr 2023 14:19:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 941E6C433D2; Mon, 17 Apr 2023 14:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681741170; bh=k3XisG/NRrAolwKyWo0Rf+luTpXJi357kD2xsaYr5I0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TmeLEFMzdEF+fN/JkBt63uYniJClN464xVCeJ7od5tLX/EyOn287IfreJBRK4vDKV TnL7gx9e4gcW1BtaTgLsov6idYrd+mmlRlDRY60KdCWlYaxkZ50+vvlxrU+Rv+2uur CKt/7j2LWsZ+DuqWpxwONv6fFN9+WfKQyxW2Rwk6Mww9lPuVx3O2Tml7Hnk8JuqfLd Z+T9PZtrRbTuc4tv3rYC/Pj4M3SDbRdhhRnEOgs5WwsR5QBSoE404NCMV+IZehvCMw q8IVCgrQq9TfJBjaXwGqBJjjGlJOTgP/OYKqXVlwEGfu/mQ8IPCbJbUpdxDprChh1O HWCKSoudNLf1w== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1poPhi-0007NG-8n; Mon, 17 Apr 2023 16:19:39 +0200 Date: Mon, 17 Apr 2023 16:19:38 +0200 From: Johan Hovold To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: Greg Kroah-Hartman , =?utf-8?B?QmrDuHJu?= Mork , me@1conan.com, erkin.bozoglu@xeront.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: serial: option: add UNISOC vendor and TOZED LT70C product Message-ID: References: <20230406055004.8216-1-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Apr 17, 2023 at 01:42:05PM +0300, Arınç ÜNAL wrote: > On 13.04.2023 18:14, Johan Hovold wrote: > > On Thu, Apr 06, 2023 at 08:50:04AM +0300, arinc9.unal@gmail.com wrote: > >> From: Arınç ÜNAL > >> > >> Add UNISOC vendor ID and TOZED LT70-C modem which is based from UNISOC > >> SL8563. The modem supports the NCM mode. > > > > Thanks for the patch. Looks mostly good, but see my comments below. > > Thanks a lot for looking at this Johan! > > > > >> T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 6 Spd=480 MxCh= 0 > >> D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > >> P: Vendor=1782 ProdID=4055 Rev=04.04 > >> S: Manufacturer=Unisoc Phone > >> S: Product=Unisoc Phone > >> S: SerialNumber= > >> C: #Ifs=14 Cfg#= 1 Atr=c0 MxPwr=500mA > >> I: If#= 0 Alt= 0 #EPs= 1 Cls=02(commc) Sub=0d Prot=00 Driver=cdc_ncm > >> E: Ad=82(I) Atr=03(Int.) MxPS= 16 Ivl=32ms > >> I: If#= 1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=01 Driver=cdc_ncm > >> E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > >> E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > >> I: If#=10 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > >> E: Ad=07(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > >> E: Ad=8b(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > >> I: If#=11 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > >> E: Ad=08(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > >> E: Ad=8c(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > >> I: If#=12 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=option > >> E: Ad=09(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > >> E: Ad=8d(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > > > This looks like an ADB interface which should be blacklisted (reserved) > > so that the driver does not bind to it. > > Will do. > > > > >> I: If#=13 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > >> E: Ad=0a(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > >> E: Ad=8e(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > >> I: If#= 2 Alt= 0 #EPs= 1 Cls=02(commc) Sub=0d Prot=00 Driver=cdc_ncm > >> E: Ad=84(I) Atr=03(Int.) MxPS= 16 Ivl=32ms > >> I: If#= 3 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=01 Driver=cdc_ncm > >> E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > >> E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > >> I: If#= 4 Alt= 0 #EPs= 1 Cls=02(commc) Sub=0d Prot=00 Driver=cdc_ncm > >> E: Ad=86(I) Atr=03(Int.) MxPS= 16 Ivl=32ms > >> I: If#= 5 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=01 Driver=cdc_ncm > >> E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > >> E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > >> I: If#= 6 Alt= 0 #EPs= 1 Cls=02(commc) Sub=0d Prot=00 Driver=cdc_ncm > >> E: Ad=88(I) Atr=03(Int.) MxPS= 16 Ivl=32ms > >> I: If#= 7 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=01 Driver=cdc_ncm > >> E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > >> E: Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > >> I: If#= 8 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > >> E: Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > >> E: Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > >> I: If#= 9 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > >> E: Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > >> E: Ad=8a(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > >> --- > >> drivers/usb/serial/option.c | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > >> index f31cc3c76329..65a050a9ca39 100644 > >> --- a/drivers/usb/serial/option.c > >> +++ b/drivers/usb/serial/option.c > >> @@ -595,6 +595,11 @@ static void option_instat_callback(struct urb *urb); > >> #define SIERRA_VENDOR_ID 0x1199 > >> #define SIERRA_PRODUCT_EM9191 0x90d3 > >> > >> +/* UNISOC (Spreadtrum) products */ > >> +#define UNISOC_VENDOR_ID 0x1782 > >> +/* TOZED TL70-C based on UNISOC SL8563 uses UNISOC's vendor ID */ > >> +#define TOZED_PRODUCT_LT70C 0x4055 > >> + > >> /* Device flags */ > >> > >> /* Highest interface number which can be used with NCTRL() and RSVD() */ > >> @@ -2225,6 +2230,7 @@ static const struct usb_device_id option_ids[] = { > >> { USB_DEVICE_AND_INTERFACE_INFO(OPPO_VENDOR_ID, OPPO_PRODUCT_R11, 0xff, 0xff, 0x30) }, > >> { USB_DEVICE_AND_INTERFACE_INFO(SIERRA_VENDOR_ID, SIERRA_PRODUCT_EM9191, 0xff, 0xff, 0x30) }, > >> { USB_DEVICE_AND_INTERFACE_INFO(SIERRA_VENDOR_ID, SIERRA_PRODUCT_EM9191, 0xff, 0, 0) }, > >> + { USB_DEVICE(UNISOC_VENDOR_ID, TOZED_PRODUCT_LT70C) }, > > > > You should match also on the interface class so that you don't try to > > bind to the cdc interfaces. See USB_DEVICE_INTERFACE_CLASS() (and > > RSVD() for the ADB interface). > > Thanks, the final result should look like this: > > { USB_DEVICE_INTERFACE_CLASS(UNISOC_VENDOR_ID, TOZED_PRODUCT_LT70C, 0xff), > .driver_info = RSVD(12) }, Alternatively, it looks like you could use USB_DEVICE_AND_INTERFACE_INFO() and match on ff/0/0. That's generally preferred as it works also if the interface numbers can change. Johan